Merge pull request #311 from estroz/set-crd-names

✨ pkg/crd/spec.go: set default ListKind and Singular CRD names
kubernetes-sigs · Sep 3, 2019 · ba11932 · ba11932
2 parents 538d4b2 + 8da6554
commit ba11932
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/crd/spec.go b/pkg/crd/spec.go
@@ -148,8 +148,10 @@ func (p *Parser) NeedCRDFor(groupKind schema.GroupKind, maxDescLen *int) {
 		Spec: apiext.CustomResourceDefinitionSpec{
 			Group: groupKind.Group,
 			Names: apiext.CustomResourceDefinitionNames{
-				Kind:   groupKind.Kind,
-				Plural: defaultPlural,
+				Kind:     groupKind.Kind,
+				ListKind: groupKind.Kind + "List",
+				Plural:   defaultPlural,
+				Singular: strings.ToLower(groupKind.Kind),
 			},
 		},
 	}

diff --git a/pkg/crd/testdata/testdata.kubebuilder.io_cronjobs.yaml b/pkg/crd/testdata/testdata.kubebuilder.io_cronjobs.yaml
@@ -9,7 +9,9 @@ spec:
   group: testdata.kubebuilder.io
   names:
     kind: CronJob
+    listKind: CronJobList
     plural: cronjobs
+    singular: cronjob
   scope: Namespaced
   version: v1
   versions: