🌱 Refactor envtest release process to update envtest index locally #1113
+9
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-envtest-script
branch
from
16020fe to
e1cb690
Compare
|
/assign @vincepri @chrischdi |
k8s-ci-robot
added
the
lgtm
|
/lgtm cancel It seems OK for me, but as seen that you are looking for further options I will remove the lgtm |
k8s-ci-robot
removed
the
lgtm
camilamacedo86
approved these changes
Dec 27, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0e77f652bb54e6234cf6aaa38815b011978fc705
|
vincepri
approved these changes
Dec 28, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, sbueringer, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
controller-tools repo is now configured in a way that blocks creation of pull requests by actions (see https://github.com/kubernetes-sigs/controller-tools/actions/runs/12463704971).
This PR changes the process. Now it's necessary to run
KUBERNETES_VERSION=v1.32.0 hack/envtest/update-envtest-releases.shand open a PR manually/hold
for now for further discussion. Maybe there's a better way