Support static configuration #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
|
cc @hakman ... here is my WIP for bare-metal support. Did you say you had some similar WIP? Do you want to upload, I'm happy to base my tinkering on your work, as it sounds like it's more fully baked... |
justinsb
force-pushed
the
wip_metal
branch
2 times, most recently
from
50e00f9 to
7b03cfb
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
This is intended to support bare-metal configurations.
justinsb
commented
Sep 1, 2024
| @@ -138,7 +138,7 @@ func (a *ExternalVolumes) FindVolumes() ([]*volumes.Volume, error) { | |||
|
|
|||
| match := true | |||
| for _, tag := range a.volumeTags { | |||
| if strings.HasPrefix(f.Name(), tag) { | |||
| if !strings.HasPrefix(f.Name(), tag) { | |||
There was a problem hiding this comment.
This just looks to be a pre-existing bug. external was not actually used anywhere, AFAIK, so I think we just fix it.
hakman
approved these changes
Sep 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.