Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial draft of Auth GEP 1494 #3500
Add initial draft of Auth GEP 1494 #3500
Changes from all commits
a9db0f1
6706fbd
19bd130
1a96448
d18137f
459753f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might leak into the "API" phase, but I think there's 2 levels to this, which are both worth an explicit mention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this point, and also that we're probably better to address this in the API phase. I'm going to leave this for now, and we'll come back to it in the next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(could compile comments like this that need to be accounted for later, but not as a part of this PR, as a TODO list right within the document)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The API that we have in mind so far - basically promoting Envoy's ext_auth API to be a Gateway API one) does have the facility to handle both of these use cases. But we can't really start talking about until this PR merges.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding:
Wouldn't authorization (i.e. granting users' privileges, or otherwise producing credentials) normally be handled by an identity provider? At least in all except the basic auth case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends - in OAuth/JWT cases yea that may be common, for other scenarios like mesh AuthZ policies, the infrastructure/identity provider just handles distribution of the authentication credentials (certificates used for mTLS in many implementations), and the actual policies are typically written as CRDs in the cluster by a platform engineer or developer, and enforced in the dataplane near the destination app, typically by a proxy.
(But this is getting way ahead of the scope we want to immediately tackle to start.)