-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cilium_enable_bbr flag for cilium #11730
base: master
Are you sure you want to change the base?
Conversation
ea25e81
to
30a0c5c
Compare
/ok-to-test |
Signed-off-by: cyclinder <[email protected]>
30a0c5c
to
8e68249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cyclinder, tico88612 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yankay, Could you take a look? thanks! |
{% if cilium_enable_bbr %} | ||
enable-bbr: "true" | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{% if cilium_enable_bbr %} | |
enable-bbr: "true" | |
{% endif %} | |
enable-bbr: "{{ cilium_enable_bbr | lower }}" |
Unless there is a downside to explicitly set if to false ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the current change, which prevents cilium from failing to start if the user-configured value is not true
or false
.
That would be better addressed by a "is boolean" test in the validation tasks.
|
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: