Support IGNORE_ERRORS when scanning from pyarrow/pandas #4646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royi-luo
force-pushed
the
royi/ignore-errors-df-polars
branch
from
3fdb113 to
2f21964
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4646 +/- ##
==========================================
- Coverage 86.40% 86.39% -0.01%
==========================================
Files 1373 1373
Lines 58250 58253 +3
Branches 7219 7216 -3
==========================================
- Hits 50329 50328 -1
- Misses 7757 7761 +4
Partials 164 164 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
royi-luo
force-pushed
the
royi/ignore-errors-df-polars
branch
2 times, most recently
from
074809c to
dbad6a6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
royi-luo
force-pushed
the
royi/ignore-errors-df-polars
branch
3 times, most recently
from
1ee740f to
ed44e03
Compare
Benchmark ResultMaster commit hash:
|
ray6080
reviewed
Dec 19, 2024
CMakeLists.txt
Outdated
| @@ -317,7 +317,7 @@ add_subdirectory(third_party) | |||
| if(${BUILD_KUZU}) | |||
| add_definitions(-DKUZU_ROOT_DIRECTORY="${PROJECT_SOURCE_DIR}") | |||
| add_definitions(-DKUZU_CMAKE_VERSION="${CMAKE_PROJECT_VERSION}") | |||
| add_definitions(-DKUZU_EXTENSION_VERSION="0.7.0") | |||
There was a problem hiding this comment.
hmm Do we need to upgrade the extension version?
There was a problem hiding this comment.
I added a virtual function to TableFuncBindData which is inherited by some classes in the extensions (e.g. JSONScanBindData) so I probably need to bump the extension version.
That single change (me needing to export ScanBindData/TableFuncBindData) caused a bunch of dynamic casts in the macos extension test to fail due to the casted targets not being exported which is why I added all those KUZU_API` changes. I'm not completely sure why they showed up now and not before though.
There was a problem hiding this comment.
okay. We don't need to bump extension version manually in PRs now. The CI pipeline will handle this.
There was a problem hiding this comment.
This is a bit strange, as we have virtual function in TableFuncBindData previously. I wonder why we don't need to mark KUZU_API previously, but now. @acquamarin Can you also take a look at the KUZU_API changes in this PR?
There was a problem hiding this comment.
It probably because the only virtual method before is copy which is pure virtual (so the definitions are all in the child classes). The method I added has a default implementation so it actually needs to exported for child classes in the extensions to access.
| @@ -17,6 +18,7 @@ namespace kuzu { | |||
| PyArrowScanConfig::PyArrowScanConfig(const common::case_insensitive_map_t<Value>& options) { | |||
There was a problem hiding this comment.
I wonder why PyArrowScan and PandasScan have different ways to convert scanConfig. I need to take another look to see if we can unify them. but can you also take a look?
There was a problem hiding this comment.
I think the reason is that we don't support the pyarrow scan options (skipNum and limitNum) in pandas scan so before this PR we don't actually support any configuration for pandas scan. I could look into if it's doable to support those options in pandas scan and if it is I'll add the support and unify the config in a separate PR.
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
ray6080
approved these changes
Dec 28, 2024
andyfengHKU
force-pushed
the
royi/ignore-errors-df-polars
branch
from
46d076d to
da4f82f
Compare
Benchmark ResultMaster commit hash:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the default
IGNORE_ERRORSbehaviour (skipping rows that trigger PK-related exceptions) when scanning from pandas/pyarrow.Fixes #4534
Contributor agreement