Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename reader config to file scan info #4673

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Conversation

andyfengHKU
Copy link
Contributor

Description

See title. The previous naming is no longer accurate.

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU force-pushed the rename-reader-config branch from ad5d643 to 08fecf4 Compare January 2, 2025 08:15
@andyfengHKU andyfengHKU force-pushed the rename-reader-config branch from 1945ac4 to 62b47c6 Compare January 2, 2025 09:20
Copy link

github-actions bot commented Jan 2, 2025

Benchmark Result

Master commit hash: 42cd8a0953cce612564f1e1212623162cd79ce6e
Branch commit hash: 59fbc414550c9409ddc7c21c7aee453c21cd02f2

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 647.83 655.90 -8.07 (-1.23%)
aggregation q28 11603.25 11034.19 569.06 (5.16%)
filter q14 130.31 127.58 2.73 (2.14%)
filter q15 130.98 136.58 -5.60 (-4.10%)
filter q16 309.20 310.15 -0.95 (-0.31%)
filter q17 455.50 452.67 2.83 (0.62%)
filter q18 1946.07 1993.42 -47.35 (-2.38%)
filter zonemap-node 89.89 91.82 -1.93 (-2.10%)
filter zonemap-node-lhs-cast 89.21 90.18 -0.97 (-1.07%)
filter zonemap-node-null 86.61 87.92 -1.31 (-1.49%)
filter zonemap-rel 5849.16 5782.66 66.50 (1.15%)
fixed_size_expr_evaluator q07 572.79 570.75 2.04 (0.36%)
fixed_size_expr_evaluator q08 817.73 803.33 14.40 (1.79%)
fixed_size_expr_evaluator q09 801.78 818.09 -16.31 (-1.99%)
fixed_size_expr_evaluator q10 239.56 240.84 -1.28 (-0.53%)
fixed_size_expr_evaluator q11 233.80 234.39 -0.59 (-0.25%)
fixed_size_expr_evaluator q12 227.62 231.27 -3.65 (-1.58%)
fixed_size_expr_evaluator q13 1467.04 1472.02 -4.99 (-0.34%)
fixed_size_seq_scan q23 117.04 115.89 1.14 (0.99%)
join q29 588.86 639.28 -50.42 (-7.89%)
join q30 9826.17 10879.72 -1053.55 (-9.68%)
join q31 3.52 4.69 -1.17 (-24.99%)
join SelectiveTwoHopJoin 50.58 54.34 -3.76 (-6.92%)
ldbc_snb_ic q35 2534.06 2623.08 -89.01 (-3.39%)
ldbc_snb_ic q36 473.75 473.85 -0.09 (-0.02%)
ldbc_snb_is q32 6.68 3.43 3.26 (95.13%)
ldbc_snb_is q33 13.06 12.01 1.05 (8.73%)
ldbc_snb_is q34 0.92 0.89 0.03 (3.23%)
multi-rel multi-rel-large-scan 1812.15 1699.30 112.85 (6.64%)
multi-rel multi-rel-lookup 28.01 31.66 -3.65 (-11.53%)
multi-rel multi-rel-small-scan 66.00 102.10 -36.10 (-35.36%)
order_by q25 136.30 138.07 -1.77 (-1.28%)
order_by q26 458.33 453.11 5.22 (1.15%)
order_by q27 1488.98 1493.31 -4.32 (-0.29%)
recursive_join recursive-join-bidirection 290.00 305.47 -15.47 (-5.07%)
recursive_join recursive-join-dense 7405.80 7447.34 -41.54 (-0.56%)
recursive_join recursive-join-path 23973.46 24098.35 -124.89 (-0.52%)
recursive_join recursive-join-sparse 1058.61 1058.22 0.39 (0.04%)
recursive_join recursive-join-trail 7392.30 7420.51 -28.22 (-0.38%)
scan_after_filter q01 175.59 171.14 4.45 (2.60%)
scan_after_filter q02 163.09 161.24 1.85 (1.15%)
shortest_path_ldbc100 q37 89.68 94.69 -5.00 (-5.29%)
shortest_path_ldbc100 q38 351.40 342.40 9.00 (2.63%)
shortest_path_ldbc100 q39 61.93 61.97 -0.04 (-0.06%)
shortest_path_ldbc100 q40 430.81 428.24 2.56 (0.60%)
var_size_expr_evaluator q03 2088.55 2092.44 -3.89 (-0.19%)
var_size_expr_evaluator q04 2219.21 2258.20 -38.98 (-1.73%)
var_size_expr_evaluator q05 2582.86 2581.68 1.19 (0.05%)
var_size_expr_evaluator q06 1348.71 1358.99 -10.28 (-0.76%)
var_size_seq_scan q19 1456.62 1474.51 -17.89 (-1.21%)
var_size_seq_scan q20 2706.06 2768.79 -62.73 (-2.27%)
var_size_seq_scan q21 2283.43 2284.08 -0.66 (-0.03%)
var_size_seq_scan q22 124.52 127.38 -2.86 (-2.24%)

@andyfengHKU andyfengHKU merged commit 672ae95 into master Jan 2, 2025
@andyfengHKU andyfengHKU deleted the rename-reader-config branch January 2, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants