Rework auto begin/commit/rollback transaction during query lifetime #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
ray6080
requested review from
andyfengHKU
and removed request for
benjaminwinger
This comment was marked as outdated.
This comment was marked as outdated.
andyfengHKU
approved these changes
Jan 2, 2025
| std::vector<PropertyDefinition> Binder::bindPropertyDefinitions( | ||
| const std::vector<ParsedPropertyDefinition>& parsedDefinitions, const std::string& tableName) { | ||
| std::vector<PropertyDefinition> definitions; | ||
| for (auto& parsedDefinition : parsedDefinitions) { | ||
| auto type = LogicalType::convertFromString(parsedDefinition.getType(), clientContext); | ||
| // For default null value, we may need to resolve its data type, as its type may not be | ||
| // resolved during parsing and thus may be ANY. | ||
| tryResolvingDataTypeForDefaultNull(parsedDefinition, type); |
There was a problem hiding this comment.
Cannot this be handled with implicitCast in l79? I don't think this is a good design.
There was a problem hiding this comment.
I actually don't know. Let me give a try, if implicitCast can handle this, it would be great.
There was a problem hiding this comment.
I cannot directly use implicitCast here because the boundExpr—after binding and implicit casting—is not actually utilized in PropertyDefinition. Instead, PropertyDefinition continues to hold the parsed expression, which is not cast.
I believe the current approach of storing ParsedExpression in PropertyDefinition is not well designed. This method essentially discards the results of binding and casting (which are only used for validation) and re-binds the default expression whenever it is needed. Will discuss with @acquamarin too and see if I should open an issue on this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4674 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 1373 1373
Lines 58263 58293 +30
Branches 7216 7210 -6
=======================================
+ Hits 50338 50364 +26
- Misses 7761 7765 +4
Partials 164 164 ☔ View full report in Codecov by Sentry. |
ray6080
force-pushed
the
remove-context-from-parser
branch
from
a4d4a02 to
455ed00
Compare
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two problems related to the usage of transactions:
For the first problem, the PR moves resolving data type of default null from Parser to Binder, thus, Parser doesn't rely on transactions.
For the second problem, the PR unifies how transactions should auto begin and commit/rollback in
TransactionHelper::runFuncInTransaction(), and avoids unnecessary begin/commits of transactions.