Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear catalog interface #4726

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Clear catalog interface #4726

merged 3 commits into from
Jan 17, 2025

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Jan 17, 2025

Description

See title.

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU force-pushed the clear-catalog-interface branch from e073111 to 71c1650 Compare January 17, 2025 06:56
Copy link

Benchmark Result

Master commit hash: cba13a1d015a316278de80ce3d2169bb0a209a87
Branch commit hash: 973303eb09304b4976b9804058eb67dd05b8f9dd

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 647.66 631.26 16.40 (2.60%)
aggregation q28 11012.32 11004.81 7.51 (0.07%)
filter q14 134.63 118.13 16.50 (13.97%)
filter q15 139.26 121.44 17.82 (14.67%)
filter q16 316.17 292.25 23.92 (8.19%)
filter q17 455.81 442.49 13.33 (3.01%)
filter q18 1949.98 1904.21 45.77 (2.40%)
filter zonemap-node 97.42 81.07 16.34 (20.16%)
filter zonemap-node-lhs-cast 97.59 85.02 12.57 (14.79%)
filter zonemap-node-null 95.63 80.96 14.67 (18.12%)
filter zonemap-rel 5813.78 5730.01 83.76 (1.46%)
fixed_size_expr_evaluator q07 580.92 567.56 13.36 (2.35%)
fixed_size_expr_evaluator q08 810.74 792.57 18.17 (2.29%)
fixed_size_expr_evaluator q09 810.31 795.71 14.61 (1.84%)
fixed_size_expr_evaluator q10 244.88 228.62 16.26 (7.11%)
fixed_size_expr_evaluator q11 237.84 222.41 15.43 (6.94%)
fixed_size_expr_evaluator q12 235.12 218.55 16.57 (7.58%)
fixed_size_expr_evaluator q13 1458.84 1444.21 14.63 (1.01%)
fixed_size_seq_scan q23 125.25 102.79 22.46 (21.85%)
join q29 643.94 614.96 28.98 (4.71%)
join q30 10114.73 11225.88 -1111.15 (-9.90%)
join q31 6.01 7.35 -1.34 (-18.23%)
join SelectiveTwoHopJoin 54.54 58.62 -4.08 (-6.95%)
ldbc_snb_ic q35 2614.49 2609.53 4.96 (0.19%)
ldbc_snb_ic q36 467.15 448.12 19.03 (4.25%)
ldbc_snb_is q32 5.93 6.13 -0.20 (-3.23%)
ldbc_snb_is q33 14.64 13.04 1.60 (12.27%)
ldbc_snb_is q34 1.33 1.41 -0.08 (-5.68%)
multi-rel multi-rel-large-scan 1577.75 1712.36 -134.62 (-7.86%)
multi-rel multi-rel-lookup 45.44 59.19 -13.74 (-23.22%)
multi-rel multi-rel-small-scan 1471.61 1572.66 -101.05 (-6.43%)
order_by q25 141.09 130.39 10.70 (8.21%)
order_by q26 477.77 461.20 16.57 (3.59%)
order_by q27 1463.46 1451.05 12.41 (0.86%)
recursive_join recursive-join-bidirection 303.68 307.47 -3.79 (-1.23%)
recursive_join recursive-join-dense 7393.40 7368.25 25.15 (0.34%)
recursive_join recursive-join-path 23826.05 23965.95 -139.91 (-0.58%)
recursive_join recursive-join-sparse 1058.80 1061.11 -2.31 (-0.22%)
recursive_join recursive-join-trail 7352.80 7323.78 29.02 (0.40%)
scan_after_filter q01 179.95 163.96 15.99 (9.76%)
scan_after_filter q02 166.63 149.14 17.48 (11.72%)
shortest_path_ldbc100 q37 85.97 89.09 -3.12 (-3.50%)
shortest_path_ldbc100 q38 375.34 371.90 3.44 (0.93%)
shortest_path_ldbc100 q39 60.06 60.94 -0.88 (-1.44%)
shortest_path_ldbc100 q40 460.21 436.11 24.10 (5.53%)
var_size_expr_evaluator q03 2066.57 2060.53 6.04 (0.29%)
var_size_expr_evaluator q04 2232.27 2198.73 33.54 (1.53%)
var_size_expr_evaluator q05 2626.19 2587.72 38.48 (1.49%)
var_size_expr_evaluator q06 1338.29 1335.39 2.90 (0.22%)
var_size_seq_scan q19 1452.60 1438.89 13.71 (0.95%)
var_size_seq_scan q20 2737.41 2724.76 12.65 (0.46%)
var_size_seq_scan q21 2298.97 2278.36 20.62 (0.90%)
var_size_seq_scan q22 130.72 124.04 6.68 (5.38%)

@andyfengHKU andyfengHKU force-pushed the clear-catalog-interface branch from 338462e to 6c39667 Compare January 17, 2025 08:04
@ray6080 ray6080 self-requested a review January 17, 2025 08:10
Copy link

Benchmark Result

Master commit hash: cba13a1d015a316278de80ce3d2169bb0a209a87
Branch commit hash: a634f904457f560a676cf391053d2ad1a68edab3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 643.04 631.26 11.78 (1.87%)
aggregation q28 11950.07 11004.81 945.26 (8.59%)
filter q14 126.75 118.13 8.62 (7.30%)
filter q15 127.50 121.44 6.06 (4.99%)
filter q16 302.64 292.25 10.39 (3.56%)
filter q17 445.01 442.49 2.52 (0.57%)
filter q18 1897.46 1904.21 -6.76 (-0.35%)
filter zonemap-node 89.14 81.07 8.07 (9.95%)
filter zonemap-node-lhs-cast 93.04 85.02 8.02 (9.43%)
filter zonemap-node-null 87.24 80.96 6.28 (7.75%)
filter zonemap-rel 5836.93 5730.01 106.91 (1.87%)
fixed_size_expr_evaluator q07 582.81 567.56 15.25 (2.69%)
fixed_size_expr_evaluator q08 801.73 792.57 9.16 (1.16%)
fixed_size_expr_evaluator q09 818.95 795.71 23.24 (2.92%)
fixed_size_expr_evaluator q10 241.99 228.62 13.37 (5.85%)
fixed_size_expr_evaluator q11 234.78 222.41 12.37 (5.56%)
fixed_size_expr_evaluator q12 231.58 218.55 13.03 (5.96%)
fixed_size_expr_evaluator q13 1487.45 1444.21 43.24 (2.99%)
fixed_size_seq_scan q23 112.45 102.79 9.66 (9.39%)
join q29 652.27 614.96 37.31 (6.07%)
join q30 10966.81 11225.88 -259.06 (-2.31%)
join q31 8.52 7.35 1.17 (15.85%)
join SelectiveTwoHopJoin 50.26 58.62 -8.36 (-14.26%)
ldbc_snb_ic q35 2600.70 2609.53 -8.83 (-0.34%)
ldbc_snb_ic q36 443.35 448.12 -4.77 (-1.06%)
ldbc_snb_is q32 6.28 6.13 0.15 (2.50%)
ldbc_snb_is q33 15.37 13.04 2.33 (17.90%)
ldbc_snb_is q34 1.43 1.41 0.01 (0.90%)
multi-rel multi-rel-large-scan 1538.10 1712.36 -174.26 (-10.18%)
multi-rel multi-rel-lookup 73.18 59.19 14.00 (23.65%)
multi-rel multi-rel-small-scan 1401.69 1572.66 -170.97 (-10.87%)
order_by q25 131.54 130.39 1.15 (0.88%)
order_by q26 455.21 461.20 -5.99 (-1.30%)
order_by q27 1444.84 1451.05 -6.21 (-0.43%)
recursive_join recursive-join-bidirection 286.90 307.47 -20.58 (-6.69%)
recursive_join recursive-join-dense 7381.04 7368.25 12.79 (0.17%)
recursive_join recursive-join-path 24145.19 23965.95 179.24 (0.75%)
recursive_join recursive-join-sparse 1051.51 1061.11 -9.60 (-0.90%)
recursive_join recursive-join-trail 7334.34 7323.78 10.56 (0.14%)
scan_after_filter q01 174.27 163.96 10.31 (6.29%)
scan_after_filter q02 159.19 149.14 10.04 (6.73%)
shortest_path_ldbc100 q37 86.00 89.09 -3.09 (-3.47%)
shortest_path_ldbc100 q38 381.87 371.90 9.97 (2.68%)
shortest_path_ldbc100 q39 66.51 60.94 5.57 (9.14%)
shortest_path_ldbc100 q40 432.58 436.11 -3.53 (-0.81%)
var_size_expr_evaluator q03 2114.02 2060.53 53.49 (2.60%)
var_size_expr_evaluator q04 2262.96 2198.73 64.23 (2.92%)
var_size_expr_evaluator q05 2668.38 2587.72 80.66 (3.12%)
var_size_expr_evaluator q06 1338.19 1335.39 2.80 (0.21%)
var_size_seq_scan q19 1450.58 1438.89 11.68 (0.81%)
var_size_seq_scan q20 2829.74 2724.76 104.98 (3.85%)
var_size_seq_scan q21 2315.16 2278.36 36.80 (1.62%)
var_size_seq_scan q22 125.84 124.04 1.80 (1.45%)

@andyfengHKU andyfengHKU marked this pull request as ready for review January 17, 2025 15:23
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyfengHKU andyfengHKU merged commit af44675 into master Jan 17, 2025
@andyfengHKU andyfengHKU deleted the clear-catalog-interface branch January 17, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants