Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update UI5 from v1 to v2 #3542

Merged
merged 60 commits into from
Jan 29, 2025
Merged

chore: update UI5 from v1 to v2 #3542

merged 60 commits into from
Jan 29, 2025

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Dec 17, 2024 •
edited by OliwiaGowor
Loading

Description

Changes proposed in this pull request:

  • updated all UI5 dependencies to V2
  • updated React to version 18
  • refactored components to the UI5 v2 API
  • adjusted e2e tests
  • migrated unit and component tests from Vitest to Cypress
  • replaced spacing from webcomponents-react with corresponding classNames
  • fixed bugs

Related issue(s)
Closes #3422

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

OliwiaGowor and others added 22 commits October 31, 2024 13:44
@OliwiaGowor
chore: UI5 bump packages (#3439)
e5930e3 
* chore: update packages

* chore: bump ui5-react

* fix: adjust tests to not use enzyme

* chore: fix dependencies

* fix: remove unused

* fix: remove not existing import

* chore: add compatibility package
@OliwiaGowor
fix: adjust render, css names and imports (#3440)
527ab33 
* fix: change render

* fix: adjust css names

* fix: change imports for Toolbar

* fix: change imports for tables

* fix: rename list comp. & badge

* fix: fix imports
@mrCherry97
chore: adjust spacing to classNames (#3442)
cd703c0 
* change some spacing to new classnames

* fix merge

* pray to god, that everything is working

* pray to god, that everything is working

* some spacing and iconEnd for ExternalLink

* some spacing and iconEnd for SA token

* add no-margin class in index.scss

* adjust the rest of the spacing

* remove unused impott

* fix stupid classNames

* adjust separatorLine to tsx and use style prop

* review changes
@OliwiaGowor
fix: Ui5 codemod adjustments (#3449)
0ff4119 
* fix: ui5 codemode adjustments

* fix: fix imports

* fix: fix table imports

* fix: fix unused
@OliwiaGowor
fix: adjust DynamicPageComponent (#3445)
7b1e4dc 
* fix: adjust dynamicPage

* fix: separate actionsBar

* fix: fix actions behavior

* fix: remove unused

* fix: fix classNames

* fix: fix empty toolbar & move banners

* fix: fix dependency

* fix: remove spacing file
@mrCherry97
fix: toast adjustments (#3462)
9c39bff
@OliwiaGowor
fix: adjust tokens (#3463)
ba9135e 
* fix: adjust tokens

* fix: adjust spacing
@OliwiaGowor
fix: adjust badges (#3464)
ce4764e 
* fix: adjust badges type names

* fix: fix type mappings

* fix: remove console.log
@OliwiaGowor
fix: adjust headers size (#3467)
c85f1bd 
* fix: add 'size' to headers

* fix: add size to headers
@mrCherry97 @OliwiaGowor
fix: defaultProps (#3469)
a565ab1 
* remove defaultProps and disableEdit prop from resourcelist

* Update src/shared/components/ResourcesList/ResourcesList.js

Co-authored-by: Oliwia Gowor <[email protected]>

---------

Co-authored-by: Oliwia Gowor <[email protected]>
@mrCherry97
fix: spinner size (#3474)
a486ff6
@OliwiaGowor
fix: theme (#3475)
c702d0c
@OliwiaGowor
fix: adjust forms (#3473)
da69d7c 
* fix: fix styling and alerts

* fix: fix unsaved message

* fix: fix background in add modules

* fix: remove unused

* fix: passing props

* fix: key error

* fix: resources in list
@OliwiaGowor
fix: adjust Preferences modal (#3476)
57d5921 
* fix: adjust Preferences modal

* fix: move import

* fix: opening preferences menu

* fix: list props
@mrCherry97
Merge branch 'main' of github.com:kyma-project/busola into ui5-migrat…
7a03881 
…e-v2
@mrCherry97
fix: props
dd3e052
@mrCherry97
fix: objectPageHeader styling and modules card (#3487)
5e543ee
@OliwiaGowor
fix: Ui5 console errors (#3486)
bcf9884 
* fix: key errors

* fix: fetch error

* fix: monaco worker fix

* fix: dynamicPage header error

* fix: small fixes

* fix: review fixes
@OliwiaGowor
fix: adjust V1 Tables (#3491)
23431fc 
* fix: adjust tables

* fix: emptyListComp flickering

* fix: adjust reset.css
@OliwiaGowor
fix: change logo acc name (#3518)
dc93f43
@chriskari
remove unnecessary css code from reset.css & some minor adjustments (#…
3517ff7 
…3524)
@OliwiaGowor @mrCherry97 @akucharska
fix: Busola is flickering when ObjectPage is opened (#3498)
5b7fd61 
* fix: fix flickering on column layout

* fix: remove unused

* fix: replace DynamicPage with ObjectPage

* fix: fix key error

* fix: banner height and remove unused

* fix: initial render flicker

* fix: change to DynamicPage

* hotfix

* Replace props spread

* hotfix

* fix: shadow & unused

* fix: shadow & sticky tabs

* fix: hide button everywhere

---------

Co-authored-by: mrCherry97 <[email protected]>
Co-authored-by: akucharska <[email protected]>
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 17, 2024
@mrCherry97 mrCherry97 changed the title Ui5 migrate v2 chore: update UI5 from v1 to v2 Dec 17, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 17, 2024
mrCherry97 and others added 3 commits December 17, 2024 12:46
@mrCherry97 @OliwiaGowor
fix: selected in lists (#3543)
71908da 
Co-authored-by: Oliwia Gowor <[email protected]>
@akucharska
fix: Fix delete cluster action (#3540)
049a830 
* Fix delete cluster action
@OliwiaGowor
fix: Toast is hidden behind Dialogs (#3538)
764bf23 
* Revert "Merge branch 'main' into ui5-migrate-v2"

This reverts commit 79fb867, reversing
changes made to 5b7fd61.

* fix: selected in lists (#3539)

* fix: toasts in dialogs
mrCherry97
mrCherry97 commented Jan 21, 2025
View reviewed changes
Copy link
Contributor Author

@mrCherry97 mrCherry97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Clicking APIGateway on the Cluster level is causing busola break
    image

chriskari
chriskari reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@chriskari chriskari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good to me. I had a thorough look through the files and tested the application but didn't encounter any bugs or styling issues.

akucharska
akucharska previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 23, 2025
@mrCherry97
Copy link
Contributor Author

/hold until #3598

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@mrCherry97
Copy link
Contributor Author

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
grego952
grego952 previously approved these changes Jan 27, 2025
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 27, 2025
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 28, 2025
@OliwiaGowor
fix: undefined in data sources (#3633)
9d6c74e 
* fix: undefined in state

* fix: stabilize test

* fix: stabilize navigation test

* fix: stabilize tests?

* move wait for cr test
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 29, 2025
@mrCherry97 mrCherry97 merged commit 86b9ab4 into main Jan 29, 2025
17 checks passed
@mrCherry97 mrCherry97 deleted the ui5-migrate-v2 branch January 29, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradPietocha KonradPietocha KonradPietocha left review comments

@chriskari chriskari chriskari left review comments

@akucharska akucharska akucharska approved these changes

@grego952 grego952 grego952 approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

@mrCherry97 mrCherry97

@KonradPietocha KonradPietocha

@grego952 grego952

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate ui5-webcomponents-react from v1 to v2
8 participants
@mrCherry97 @akucharska @KonradPietocha @grego952 @OliwiaGowor @chriskari @kyma-bot @dbadura