Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Disable proxy endpoint #3681

Merged
merged 1 commit into from
Feb 11, 2025
Merged

chore: Disable proxy endpoint #3681

merged 1 commit into from
Feb 11, 2025

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Feb 11, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

Related issue(s)
Closes #3679

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2025
@mrCherry97 mrCherry97 marked this pull request as ready for review February 11, 2025 09:30
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 11, 2025
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 11, 2025
@mrCherry97
Copy link
Contributor Author

/override tide

@kyma-bot
Copy link
Contributor

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit a38f58b into kyma-project:main Feb 11, 2025
43 of 45 checks passed
@mrCherry97 mrCherry97 deleted the chore-disable-proxy branch February 11, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskari chriskari chriskari approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable cors proxy endpoint until the proper user tracking is in place
3 participants
@mrCherry97 @kyma-bot @chriskari