feat: Add state of the Kyma modules in cluster overview #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
OliwiaGowor
requested review from
a team,
akucharska,
mrCherry97,
dbadura and
chriskari
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
mrCherry97
requested changes
Feb 13, 2025
public/i18n/en.yaml
Outdated
Comment on lines
45
to
47
| modules-ready: 'Ready' | ||
| modules-error: 'Error' | ||
| modules-warning: 'Warning' |
There was a problem hiding this comment.
we have it in common.stauses, probably it will be better to not make additional duplicated state
statuses:
error: Error
ready: Ready
unknown: Unknown
| subTitle={t('kyma-modules.installed-modules')} | ||
| extraInfo={[ | ||
| { | ||
| title: t('cluster-overview.statistics.modules-ready'), |
mrCherry97
requested changes
Feb 17, 2025
| @@ -61,6 +66,58 @@ export function useModuleStatus(resource: KymaResourceType) { | |||
| return { data, loading, error }; | |||
| } | |||
|
|
|||
| export function useModulesStatuses(modules: any[]) { | |||
There was a problem hiding this comment.
we have 2 functions, one to get status for one module, and this to get all of the statuses, please rename this function to be more different in naming than the 1 one. Maybe useGetAllModulesStatuses or useAllModulesStatuses
| } | ||
| /> | ||
| </div> | ||
| <CountingCard |
There was a problem hiding this comment.
Please move it to a separate file, components + moduleCounts
| error: statusesError, | ||
| } = useModulesStatuses(modules); | ||
|
|
||
| const moduleCounts = useMemo(() => { |
There was a problem hiding this comment.
maybe name it moduleStatusCounts or countModuleStatuses, will be a little bit clearer
mrCherry97
approved these changes
Feb 17, 2025
grego952
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3659
Definition of done
backlog#4567