feat: Update cpu and memory charts on namespace #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
do-not-merge/work-in-progress
KonradPietocha
changed the title
KonradPietocha
requested review from
akucharska,
mrCherry97,
dbadura,
chriskari and
OliwiaGowor
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
dbadura
requested changes
Feb 18, 2025
| return podsMetrics.reduce((accData, pod) => { | ||
| return { | ||
| cpu: { | ||
| usage: accData.cpu.usage + (pod?.cpu?.usage ?? 0), |
There was a problem hiding this comment.
I would consider to wrap all addition by getCpus or getBytes functions because sometimes k8s can return values with different prefix.
dbadura
requested changes
Feb 20, 2025
| <React.Fragment key="resource-quota-limits"> | ||
| {(!!podsMetrics?.length || !isEmpty(resource?.status)) && ( | ||
| <div className="cluster-stats sap-margin-tiny"> | ||
| {mapUsagesToChartsData(podsMetrics).map((chartData, index) => ( |
There was a problem hiding this comment.
What do you think about merging those 2 tables before rendering happen and then render it?
It would remove duplication of code.
| } as UseGetOptions) as { data: NodeList | null }; | ||
|
|
||
| // Finding capacity for a given usage. | ||
| const getAllocatable = ( |
There was a problem hiding this comment.
It can be move as separate function. It's very long and it's inside function
dbadura
reviewed
Feb 20, 2025
| > | ||
| {scope.scopeName} | ||
| </Title> | ||
| (resource: ResourceQuotaProps) => ( |
There was a problem hiding this comment.
Would you like to rename ResourceQuotaProps to ResourceQuota because this type looks like k8s ResourceQuota
| cy.contains('Events') | ||
| .scrollIntoView() | ||
| .should('be.visible'); | ||
| }); | ||
|
|
||
| it('checks the visibility of charts', () => { |
There was a problem hiding this comment.
Why this test checks errors and loading?
I think it should check if charts are available and visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Closes #3592
Definition of done
backlog#4567