Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to restore etcd backup from s3 to a cluster with a different name #168

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

Aveek-Saha
Copy link
Contributor

Description

Feature: Currently the etcd backup restore from s3 assumes that the restored cluster and the original cluster share the same name. This PR allows restoring to a cluster with a different name from the original. This change enables the deletion of the old nodes from the new cluster.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?

I've tested this by restoring a backup from s3 using a cluster with a different name from the original cluster

@MonolithProjects MonolithProjects self-assigned this Nov 9, 2023
tasks/first_server.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MonolithProjects MonolithProjects added the enhancement New feature or request label Nov 10, 2023
@MonolithProjects MonolithProjects merged commit 000fc21 into lablabs:main Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants