-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added option to customize kubelet arguments #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@MonolithProjects I just noticed i named the variable rke_kubelet_arg instead of rke2_kubelet_arg and pushed another commit just to stay consistent across all vars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks. I didn't notice that too. |
Hello, # rke2_kube_controller_manager_arg:
# - "bind-address=0.0.0.0"
# rke2_kube_scheduler_arg:
# - "bind-address=0.0.0.0" Like this (I have removed # (Optional) Customize default kubelet arguments
# rke2_kubelet_arg:
# - "system-reserved=cpu=100m,memory=100Mi" instead of: # (Optional) Customize default kubelet arguments
# rke2_kubelet_arg:
# - "--system-reserved=cpu=100m,memory=100Mi" |
Description
Added option to customize kubelet arguments (https://docs.rke2.io/reference/server_config#agentflags).
I used the variable rke2_server_options somewhat successfully too, but it becomes very messy very fast since it requires specifying all kubelet arguments on a single line like so:
I would constantly break it trying to add new/adjust existing arguments so i created a new variable so that arguments can be passed like below:
Type of change
How Has This Been Tested?
I have been successfully using this variable on all my environments both dev/test and production in the last month or so.