PHP 8.3 support. Config testing. Correct mysql.cnf name. (#53)

* PHP 8.3 support. Config testing. Correct mysql.cnf name. * #45: Make php 8.3 the default. * #45: 8.3 defaults in tests. * Delete unncessary 7.4 test.
lando · Feb 27, 2024 · 5a8d8f1 · 5a8d8f1
1 parent 1cb1a58
commit 5a8d8f1
Show file tree

Hide file tree

Showing 20 changed files with 70 additions and 114 deletions.
diff --git a/.github/workflows/pr-laravel-tests.yml b/.github/workflows/pr-laravel-tests.yml
@@ -27,7 +27,6 @@ jobs:
           - examples/laravel-nginx
           - examples/7.1
           - examples/7.2
-          - examples/7.4
     steps:
       - name: Checkout code
         uses: actions/checkout@v3

diff --git a/builders/laravel.js b/builders/laravel.js
@@ -213,7 +213,7 @@ module.exports = {
     defaultFiles: {
       php: 'php.ini',
     },
-    php: '7.4',
+    php: '8.3',
     services: {appserver: {overrides: {environment: {
       APP_LOG: 'errorlog',
     }}}},

diff --git a/config/default.conf.tpl b/config/default.conf.tpl
@@ -1,3 +1,5 @@
+# LANDOLARAVELNGINXCONF
+
 server {
 
     listen 80 default_server;

diff --git a/config/mysql.conf → config/mysql.cnf b/config/mysql.conf → config/mysql.cnf
@@ -1,6 +1,7 @@
 #
 # The MySQL database server configuration file for Lando
 #
+# LANDOLARAVELMYSQLCNF
 
 [mysqld]
 #
@@ -71,7 +72,7 @@ max_binlog_size = 100M
 #innodb_buffer_pool_size = 384M
 #innodb_additional_mem_pool_size = 20M
 # Set .._log_file_size to 25 % of buffer pool size
-innodb_log_file_size = 100M
+innodb_log_file_size = 101M
 #innodb_log_buffer_size = 8M
 innodb_flush_log_at_trx_commit = 0
 #innodb_lock_wait_timeout = 50
@@ -82,7 +83,7 @@ innodb_open_files       = 256
 innodb_io_capacity      = 512
 innodb_flush_method     = O_DIRECT
 innodb_thread_concurrency = 8
-innodb_lock_wait_timeout = 120
+innodb_lock_wait_timeout = 121
 #
 # * Security Features
 #

diff --git a/config/mysql8.cnf b/config/mysql8.cnf
@@ -1,6 +1,7 @@
 #
 # The MySQL database server configuration file for Lando
 #
+# LANDOLARAVELMYSQL8CNF
 
 [mysqld]
 #
@@ -49,7 +50,7 @@ read_buffer_size = 2M
 #server-id    = 1
 #log_bin      = /src/.lando/log/mysql-bin.log
 expire_logs_days = 10
-max_binlog_size = 100M
+max_binlog_size = 101M
 #binlog_do_db   = include_database_name
 #binlog_ignore_db = include_database_name
 #
@@ -77,7 +78,7 @@ innodb_open_files       = 256
 innodb_io_capacity      = 512
 innodb_flush_method     = O_DIRECT
 innodb_thread_concurrency = 8
-innodb_lock_wait_timeout = 120
+innodb_lock_wait_timeout = 127
 #
 # * Security Features
 #

diff --git a/config/php.ini b/config/php.ini
@@ -1,5 +1,6 @@
 [PHP]
 
+; LANDOLARAVELPHPINI
 ;;;;;;;;;;;;;;;
 ; PHP Globals ;
 ;;;;;;;;;;;;;;;
@@ -36,8 +37,8 @@ xdebug.mode = ${XDEBUG_MODE}
 
 ; Globals
 expose_php = on
-max_execution_time = 90
-max_input_time = 900
+max_execution_time = 91
+max_input_time = 901
 max_input_vars = 10000
 memory_limit = ${PHP_MEMORY_LIMIT}
 upload_max_filesize = 100M

diff --git a/docs/index.md b/docs/index.md
@@ -12,7 +12,7 @@ Lando offers a configurable [recipe](https://docs.lando.dev/core/v3/recipes.html
 
 #### Features of this plugin:
 
-* Configurable `php` version from `5.3` all the way to `8.1`
+* Configurable `php` version from `5.3` all the way to `8.3`
 * Configurable `webroot`
 * Configurable web server (`apache` or `nginx`)
 * Configurable database backend (`mariadb`, `mysql`, or `postgres`)

diff --git a/examples/.lando.local.yml b/examples/.lando.local.yml
diff --git a/examples/.lando.upstream.yml b/examples/.lando.upstream.yml
@@ -1,2 +1,2 @@
 plugins:
-  "@lando/laravel": ../../..
+  "@lando/laravel": ./../../../
diff --git a/examples/7.1/README.md b/examples/7.1/README.md
@@ -16,7 +16,7 @@ lando poweroff
 
 # Initialize an empty laravel recipe
 rm -rf laravel && mkdir -p laravel && cd laravel
-cp -f ../../.lando.local.yml .lando.local.yml && cat .lando.local.yml
+cp -f ../../.lando.upstream.yml .lando.upstream.yml && cat .lando.upstream.yml
 lando init --source cwd --recipe laravel --webroot app/public --name lando-laravel --option cache=redis --option php='7.1' --option composer_version='1-latest'
 
 # Should compose create-project a new laravel app

diff --git a/examples/7.2/README.md b/examples/7.2/README.md
@@ -17,7 +17,7 @@ lando poweroff
 # Initialize an empty laravel recipe
 rm -rf laravel && mkdir -p laravel && cd laravel
 lando init --source cwd --recipe laravel --webroot app/public --name lando-laravel --option cache=redis --option php='7.2' --option composer_version='1-latest'
-cp -f ../../.lando.local.yml .lando.local.yml && cat .lando.local.yml
+cp -f ../../.lando.upstream.yml .lando.upstream.yml && cat .lando.upstream.yml
 
 # Should compose create-project a new laravel app
 cd laravel

diff --git a/examples/7.4/.gitignore b/examples/7.4/.gitignore
diff --git a/examples/7.4/README.md b/examples/7.4/README.md
diff --git a/examples/laravel-custom/.lando.yml b/examples/laravel-custom/.lando.yml
@@ -1,7 +1,7 @@
 name: laravel-custom
 recipe: laravel
 config:
-  php: '7.4'
+  php: '8.3'
   composer_version: '2.0.7'
   via: nginx:1.17
   webroot: bob
@@ -13,6 +13,12 @@ config:
     php: config/php.ini
     vhosts: config/default.conf
 
+services:
+  appserver:
+    overrides:
+      environment:
+        PHP_MEMORY_LIMIT: 2G
+
 # do not remove this
 plugins:
   "@lando/laravel": ../..

diff --git a/examples/laravel-custom/README.md b/examples/laravel-custom/README.md
@@ -28,15 +28,25 @@ lando ssh -s appserver -c "curl -L appserver_nginx" | grep "HI BOB"
 lando ssh -s appserver_nginx -c "nginx -v" 2>&1 | grep "nginx version" | grep "nginx/1.17"
 lando ssh -s appserver -c "curl -IL appserver_nginx" | grep Server | grep nginx
 
-# Should use php 7.4
-lando php -v | grep "PHP 7.4"
+# Should use php 8.3
+lando php -v | grep "PHP 8.3"
 
 # Should use composer 2.0.7
 lando ssh -s appserver -c "/bin/sh -c 'NO_COLOR=1 composer -V'" | grep "Composer version 2.0.7"
 
 # Should be running mysql 5.7 by default
 lando mysql -V | grep 5.7
 
+# Should have COMPOSER_MEMORY_LIMIT set to -1
+lando ssh -s appserver -c "env" | grep "COMPOSER_MEMORY_LIMIT=-1"
+
+# Should allow environment variable PHP_MEMORY_LIMIT to work if used in config file
+lando ssh -s appserver -c "curl -L appserver_nginx/info.php" | grep memory_limit | grep 2G
+
+# Should have unlimited memory for php for CLI opts
+lando php -i | grep memory_limit | grep -e "-1"
+lando ssh -s appserver -c "php -i" | grep "memory_limit" | grep -e "-1"
+
 # Should be able to connect to the database with the default creds
 lando mysql laravel -e quit
 
@@ -47,7 +57,7 @@ lando ssh -s cache -c "memcached --version | grep 1.5.12"
 lando php -m | grep Xdebug
 
 # Should be using custom config files
-lando ssh -s appserver -c "curl -L appserver_nginx/info.php" | grep memory_limit | grep 513M
+lando ssh -s appserver -c "curl -L appserver_nginx/info.php" | grep max_execution_time | grep 92
 lando ssh -s appserver_nginx -c "cat /opt/bitnami/nginx/conf/vhosts/lando.conf" | grep server_name | grep pirog
 lando mysql -u root -e "show variables;" | grep thread_cache_size | grep 12
 ```

diff --git a/examples/laravel-custom/config/php.ini b/examples/laravel-custom/config/php.ini
@@ -36,10 +36,10 @@ xdebug.mode = ${XDEBUG_MODE}
 
 ; Globals
 expose_php = on
-max_execution_time = 90
+max_execution_time = 92
 max_input_time = 900
 max_input_vars = 10000
-memory_limit = 513M
+memory_limit = ${PHP_MEMORY_LIMIT}
 upload_max_filesize = 100M
 post_max_size = 100M
 error_reporting = E_ALL & ~E_DEPRECATED

diff --git a/examples/laravel-defaults/README.md b/examples/laravel-defaults/README.md
@@ -24,8 +24,8 @@ Run the following commands to validate things are rolling as they should.
 # Should serve from app root by default
 lando ssh -s appserver -c "curl -L localhost" | grep "DEFAULTS"
 
-# Should use 7.4 as the default php version
-lando php -v | grep "PHP 7.4"
+# Should use 8.3 as the default php version
+lando php -v | grep "PHP 8.3"
 
 # Should be running apache 2.4 by default
 lando ssh -s appserver -c "apachectl -V | grep 2.4"
@@ -34,12 +34,28 @@ lando ssh -s appserver -c "curl -IL localhost" | grep Server | grep 2.4
 # Should be running mysql 5.7 by default
 lando mysql -V | grep 5.7
 
+# Should have COMPOSER_MEMORY_LIMIT set to -1
+lando ssh -s appserver -c "env" | grep "COMPOSER_MEMORY_LIMIT=-1"
+
+# Should have a 1G php mem limit on appserver
+lando ssh -s appserver -c "curl http://localhost/info.php" | grep "memory_limit" | grep "1G"
+
+# Should have unlimited memory for php for CLI opts
+lando php -i | grep memory_limit | grep -e "-1"
+lando ssh -s appserver -c "php -i" | grep "memory_limit" | grep -e "-1"
+
 # Should not enable xdebug by default
 lando php -m | grep xdebug || echo $? | grep 1
 
 # Should use the default database connection info
 lando mysql laravel -e quit
 
+# Should use the correct default config files
+lando ssh -s appserver -c "cat /usr/local/etc/php/conf.d/zzz-lando-my-custom.ini" | grep "; LANDOLARAVELPHPINI"
+lando ssh -s appserver -c "curl -L http://localhost/info.php" | grep max_execution_time | grep 91
+lando ssh -s database -c "cat /opt/bitnami/mysql/conf/my_custom.cnf" | grep "LANDOLARAVELMYSQLCNF"
+lando mysql -u root -e "show variables;" | grep innodb_lock_wait_timeout | grep 121
+
 # Should use composer 2 by default
 lando ssh -s appserver -c "/bin/sh -c 'NO_COLOR=1 composer -V'" | grep "Composer version 2."
 ```

diff --git a/examples/laravel-init/README.md b/examples/laravel-init/README.md
@@ -1,4 +1,4 @@
-Laravel PHP 8.1 Example
+Laravel Init Example
 ===============
 
 This example exists primarily to test the following documentation:
@@ -16,8 +16,8 @@ lando poweroff
 
 # Initialize an empty laravel recipe
 rm -rf laravel && mkdir -p laravel && cd laravel
-lando init --source cwd --recipe laravel --webroot app/public --name lando-laravel --option cache=redis --option php='8.1'
-cp -f ../../.lando.local.yml .lando.local.yml && cat .lando.local.yml
+lando init --source cwd --recipe laravel --webroot app/public --name lando-laravel --option cache=redis
+cp -f ../../.lando.upstream.yml .lando.upstream.yml && cat .lando.upstream.yml
 
 # Should compose create-project a new laravel app
 cd laravel
@@ -42,9 +42,9 @@ lando ssh -s appserver -c "curl -L localhost" | grep "Laravel"
 cd laravel
 lando ssh -s appserver -c 'cd /var/www/.composer && composer show laravel/installer' | grep 'v4.'
 
-# Should use 7.4 as the default php version
+# Should use 8.3 as the default php version
 cd laravel
-lando php -v | grep "PHP 8.1"
+lando php -v | grep "PHP 8.3"
 
 # Should be running apache 2.4 by default
 cd laravel

diff --git a/examples/laravel-mysql8/README.md b/examples/laravel-mysql8/README.md
@@ -17,7 +17,7 @@ lando poweroff
 # Initialize an empty laravel recipe
 rm -rf mysql8 && mkdir -p mysql8 && cd mysql8
 lando init --source cwd --recipe laravel --webroot app/public --name lando-laravel-mysql8 --option cache=redis --option php='8.1' --option database=mysql:8.0.22
-cp -f ../../.lando.local.yml .lando.local.yml && cat .lando.local.yml
+cp -f ../../.lando.upstream.yml .lando.upstream.yml && cat .lando.upstream.yml
 
 # Should compose create-project a new laravel app
 cd mysql8
@@ -67,6 +67,11 @@ lando ssh -s cache -c "redis-cli CONFIG GET databases"
 cd mysql8
 lando mysql -ularavel -plaravel laravel -e quit
 
+# Should use the defauly mysql8 config file
+cd mysql8
+lando ssh -s database -c "cat /opt/bitnami/mysql/conf/my_custom.cnf" | grep "LANDOLARAVELMYSQL8CNF"
+lando mysql -u root -e "show variables;" | grep innodb_lock_wait_timeout | grep 127
+
 # Should have artisan available
 cd mysql8
 lando artisan env

diff --git a/examples/laravel-nginx/README.md b/examples/laravel-nginx/README.md
@@ -32,6 +32,9 @@ lando nginx -v 2>&1 | grep "nginx version" | grep "nginx/1.25"
 
 # Should use the php version specified by the user eg 7.4
 lando php -v | grep "PHP 7.4"
+
+# Should load the correct default nginx config
+lando ssh -s appserver_nginx -c "cat /opt/bitnami/nginx/conf/vhosts/lando.conf" | grep "LANDOLARAVELNGINXCONF"
 ```
 
 Destroy tests