fix: stop dead branch in proc macro from emitting clippy::missing_panics_doc #3595
Conversation
| ::std::panic!(); | ||
| // `panic!` would be enough here but we would then get a warning on `clippy::missing_panics_doc` | ||
| // SAFETY: this branch is never reached. | ||
| unsafe { ::std::hint::unreachable_unchecked() } |
There was a problem hiding this comment.
I don't like emitting unsafe from the macros for any reason, honestly. Does unreachable!() emit the same lint warning?
There was a problem hiding this comment.
Alternatively, just #[allow] the lint.
There was a problem hiding this comment.
This is effectively identical.
The compiler should be able to figure out that anything in if false {...} is unreachable ^^
Though I think clippy should also alert for this (it is still a panic just with a better name. If clippy is not, this is a false negative).
| unsafe { ::std::hint::unreachable_unchecked() } | |
| #[allow(clippy::missing_panics_doc)] | |
| ::std::unreachable!(); |
|
Not going to accept this as-is due to the |
|
Well that's really annoying: https://github.com/launchbadge/sqlx/actions/runs/12595539052/job/35105015509?pr=3663#step:10:235 |
|
It appears that There is also the |
* chore: create 0.8.3 release * fix: prevent dead-branch warning from Clippy in query macros cc #3595 * fix: move `#[allow]` from previous commit to the `if` block
fixes #3594