Remove verbose FFmpeg option

lay295 · Apr 6, 2024 · 9e7e43a · 9e7e43a
1 parent f843c2c
commit 9e7e43a
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 14 deletions.
diff --git a/TwitchDownloaderCLI/Modes/Arguments/ChatRenderArgs.cs b/TwitchDownloaderCLI/Modes/Arguments/ChatRenderArgs.cs
@@ -116,9 +116,6 @@ internal sealed class ChatRenderArgs : TwitchDownloaderArgs
         [Option("temp-path", Default = "", HelpText = "Path to temporary folder to use for cache.")]
         public string TempFolder { get; set; }
 
-        [Option("verbose-ffmpeg", Default = false, HelpText = "Prints every message from FFmpeg.")]
-        public bool LogFfmpegOutput { get; set; }
-
         [Option("skip-drive-waiting", Default = false, HelpText = "Do not wait for the output drive to transmit a ready signal before writing the next frame. Waiting is usually only necessary on low-end USB drives.")]
         public bool SkipDriveWaiting { get; set; }
 

diff --git a/TwitchDownloaderCLI/Modes/RenderChat.cs b/TwitchDownloaderCLI/Modes/RenderChat.cs
@@ -79,7 +79,6 @@ private static ChatRenderOptions GetRenderOptions(ChatRenderArgs inputOptions, I
                     "system" or "none" => EmojiVendor.None,
                     _ => throw new NotSupportedException("Invalid emoji vendor. Valid values are: 'twitter' / 'twemoji', and 'google' / 'notocolor'")
                 },
-                LogFfmpegOutput = inputOptions.LogFfmpegOutput,
                 SkipDriveWaiting = inputOptions.SkipDriveWaiting,
                 EmoteScale = inputOptions.ScaleEmote,
                 BadgeScale = inputOptions.ScaleBadge,

diff --git a/TwitchDownloaderCore/ChatRenderer.cs b/TwitchDownloaderCore/ChatRenderer.cs
@@ -382,16 +382,13 @@ private FfmpegProcess GetFfmpegProcess(int partNumber, bool isMask)
                 SavePath = savePath
             };
 
-            if (renderOptions.LogFfmpegOutput && _progress != null)
+            process.ErrorDataReceived += (_, e) =>
             {
-                process.ErrorDataReceived += (_, e) =>
+                if (e.Data != null)
                 {
-                    if (e.Data != null)
-                    {
-                        _progress.LogFfmpeg(e.Data);
-                    }
-                };
-            }
+                    _progress.LogFfmpeg(e.Data);
+                }
+            };
 
             process.Start();
             process.BeginErrorReadLine();

diff --git a/TwitchDownloaderCore/Options/ChatRenderOptions.cs b/TwitchDownloaderCore/Options/ChatRenderOptions.cs
@@ -83,7 +83,6 @@ public string MaskFile
         public int AccentStrokeWidth => (int)(8 * ReferenceScale * AccentStrokeScale);
         public int AccentIndentWidth => (int)(32 * ReferenceScale * AccentIndentScale);
         public bool Offline { get; set; }
-        public bool LogFfmpegOutput { get; set; } = false;
         public bool BlockArtPreWrap { get; set; } = false;
         public double BlockArtPreWrapWidth { get; set; }
         public float BlockArtCharWidth { get; set; }

diff --git a/TwitchDownloaderWPF/PageChatRender.xaml.cs b/TwitchDownloaderWPF/PageChatRender.xaml.cs
@@ -136,7 +136,6 @@ public ChatRenderOptions GetOptions(string filename)
                 Offline = checkOffline.IsChecked.GetValueOrDefault(),
                 AllowUnlistedEmotes = true,
                 DisperseCommentOffsets = checkDispersion.IsChecked.GetValueOrDefault(),
-                LogFfmpegOutput = true
             };
             if (RadioEmojiNotoColor.IsChecked == true)
                 options.EmojiVendor = EmojiVendor.GoogleNotoColor;