Fix old settings overwriting new settings on upgrade

lay295 · Jun 5, 2021 · f6cbca4 · f6cbca4
1 parent 6c8cbf9
commit f6cbca4
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 2 deletions.
diff --git a/TwitchDownloaderWPF/App.config b/TwitchDownloaderWPF/App.config
@@ -119,6 +119,9 @@
       <setting name="SubMessages" serializeAs="String">
         <value>True</value>
       </setting>
+      <setting name="UpgradeRequired" serializeAs="String">
+        <value>True</value>
+      </setting>
     </TwitchDownloader.Properties.Settings>
   </userSettings>
 </configuration>
diff --git a/TwitchDownloaderWPF/MainWindow.xaml.cs b/TwitchDownloaderWPF/MainWindow.xaml.cs
@@ -69,8 +69,13 @@ private void btnQueue_Click(object sender, RoutedEventArgs e)
         private async void Window_Loaded(object sender, RoutedEventArgs e)
         {
             Main.Content = pageVodDownload;
-            Settings.Default.Upgrade();
-            Settings.Default.Save();
+            if (Settings.Default.UpgradeRequired)
+            {
+                Settings.Default.Upgrade();
+                Settings.Default.UpgradeRequired = false;
+                Settings.Default.Save();
+            }
+
             if (!File.Exists("ffmpeg.exe"))
                 await FFmpegDownloader.GetLatestVersion(FFmpegVersion.Full);
 

diff --git a/TwitchDownloaderWPF/Properties/Settings.Designer.cs b/TwitchDownloaderWPF/Properties/Settings.Designer.cs
diff --git a/TwitchDownloaderWPF/Properties/Settings.settings b/TwitchDownloaderWPF/Properties/Settings.settings
@@ -95,5 +95,8 @@
     <Setting Name="SubMessages" Type="System.Boolean" Scope="User">
       <Value Profile="(Default)">True</Value>
     </Setting>
+    <Setting Name="UpgradeRequired" Type="System.Boolean" Scope="User">
+      <Value Profile="(Default)">True</Value>
+    </Setting>
   </Settings>
 </SettingsFile>