Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default readable username colors to true #1137

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Default readable username colors to true #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77e7650
Default readable username colors to true
ScrubN Jul 7, 2024
3c7e4d3
Default WPF update time to 0.2
ScrubN Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TwitchDownloaderCLI/Modes/Arguments/ChatRenderArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal sealed class ChatRenderArgs : IFileCollisionArgs, ITwitchDownloaderArgs
[Option("alternate-backgrounds", Default = false, HelpText = "Alternates the background color of every other chat message to help tell them apart.")]
public bool AlternateMessageBackgrounds { get; set; }

[Option("readable-colors", Default = false, HelpText = "Increases the contrast of usernames against the background or outline color.")]
[Option("readable-colors", Default = true, HelpText = "Increases the contrast of usernames against the background or outline color.")]
public bool AdjustUsernameVisibility { get; set; }

[Option("offline", Default = false, HelpText = "Render completely offline using only embedded emotes, badges, and bits from the input json.")]
Expand Down
2 changes: 1 addition & 1 deletion TwitchDownloaderCLI/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ Other = `1`, Broadcaster = `2`, Moderator = `4`, VIP = `8`, Subscriber = `16`, P
(Default: `false`) Alternates the background color of every other chat message to help tell them apart.

**--readable-colors**
(Default: `false`) Increases the contrast of usernames against the background or outline color.
(Default: `true`) Increases the contrast of usernames against the background or outline color.

**--offline**
(Default: `false`) Render completely offline using only embedded emotes, badges, and bits from the input json.
Expand Down
4 changes: 2 additions & 2 deletions TwitchDownloaderWPF/App.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<value>700</value>
</setting>
<setting name="UpdateTime" serializeAs="String">
<value>0.1</value>
<value>0.2</value>
</setting>
<setting name="FFZEmotes" serializeAs="String">
<value>True</value>
Expand Down Expand Up @@ -230,7 +230,7 @@
<value>30</value>
</setting>
<setting name="AdjustUsernameVisibility" serializeAs="String">
<value>False</value>
<value>True</value>
</setting>
<setting name="VodTrimMode" serializeAs="String">
<value>1</value>
Expand Down
4 changes: 2 additions & 2 deletions TwitchDownloaderWPF/Properties/Settings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions TwitchDownloaderWPF/Properties/Settings.settings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<Value Profile="(Default)">700</Value>
</Setting>
<Setting Name="UpdateTime" Type="System.Double" Scope="User">
<Value Profile="(Default)">0.1</Value>
<Value Profile="(Default)">0.2</Value>
</Setting>
<Setting Name="FFZEmotes" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">True</Value>
Expand Down Expand Up @@ -225,7 +225,7 @@
<Value Profile="(Default)">30</Value>
</Setting>
<Setting Name="AdjustUsernameVisibility" Type="System.Boolean" Scope="User">
<Value Profile="(Default)">False</Value>
<Value Profile="(Default)">True</Value>
</Setting>
<Setting Name="VodTrimMode" Type="System.Int32" Scope="User">
<Value Profile="(Default)">1</Value>
Expand Down
Loading