Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made padding consistent by adding h3 class to ProgramGrid component and using that instead of passing a subtitle prop for the subtitle #6087

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −1
Open

made padding consistent by adding h3 class to ProgramGrid component and using that instead of passing a subtitle prop for the subtitle #6087

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a199d8c
fixed issue by modifying css of wrapper and using h3 for subtitle
FaatimaAbidi Nov 16, 2024
860d443
Fixed the issue by adding the h3 css to the pageHeader component and …
FaatimaAbidi Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/sections/Careers/Careers-Programs-grid/ProgramGrid.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
import styled from "styled-components";
export const ProgramsPageWrapper = styled.div`

margin-top: -2rem;

h3 {
color: ${(props) => props.theme.whiteSixToGreen3C494F};
margin: 0;
padding: 0;
font-weight: 500;
text-align: center;
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1);
}

h1{
color: ${props => props.theme.text};
transition: 0.8s cubic-bezier(0.2, 0.8, 0.2, 1);
Expand Down
3 changes: 2 additions & 1 deletion src/sections/Careers/Careers-Programs-grid/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ const ProgramsGrid = ({ hide_path, sub_section }) => {

return (
<ProgramsPageWrapper>
<PageHeader title="Open Source Internship Programs" subtitle="Build Your Career at Layer5" path={path} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this pageheader used elsewhere also, i guess yes. So why only here the subtitle having the css issues and not elsewhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the pageHeader is used in other components too, and the subtitle has css issues in those places as well. For example, the issue exists on this page as well: https://layer5.io/community/members

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudhanshutech instead of the fix I did for the current page, should I fix the issue for all pages by adding the h3 class to the page header subtitle component?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FaatimaAbidi It should be for all page headings. You can add to components

<PageHeader className="title" title="Open Source Internship Programs" path={path} />
<h3>Build Your Career at Layer5</h3>
<div className={sub_section ? "sub-header_wrapper" : "programs-page-wrapper"}>
<Container>
<div className="program-grid-wrapper">
Expand Down