Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra logic if measurand not accepted #1101

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Extra logic if measurand not accepted #1101

merged 4 commits into from
Mar 23, 2024

Conversation

drc38
Copy link
Collaborator

@drc38 drc38 commented Mar 2, 2024

Potentially fixes #1099 #1096

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.63%. Comparing base (1035e6c) to head (cbd65db).
Report is 3 commits behind head on main.

❗ Current head cbd65db differs from pull request most recent head d8041dd. Consider uploading reports for the commit d8041dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   90.57%   90.63%   +0.05%     
==========================================
  Files          10       10              
  Lines        1380     1388       +8     
  Branches      228      229       +1     
==========================================
+ Hits         1250     1258       +8     
  Misses         74       74              
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drc38 drc38 requested a review from lbbrhzn March 2, 2024 21:18
@drc38 drc38 mentioned this pull request Mar 2, 2024
@drc38
Copy link
Collaborator Author

drc38 commented Mar 14, 2024

@lbbrhzn appreciate if you merge this into main as it appears to fix the issues reported. Or if you approve and then I think I can do the merge if that's easier.

@lbbrhzn lbbrhzn merged commit 3ac7db6 into main Mar 23, 2024
6 checks passed
@lbbrhzn lbbrhzn deleted the fix-measurand branch March 23, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charger continually reboots
2 participants