style(php): apply cs fixer and phpstan

Handler/RotatingFileHandler.php

@@ -3,23 +3,8 @@
 namespace LePhare\Import\Handler;
 
 use Monolog\Handler\RotatingFileHandler as BaseRotatingFileHandler;
-use Monolog\Logger;
 
-if (Logger::API === 1) {
-    class RotatingFileHandler extends BaseRotatingFileHandler
-    {
-        use RotatingFileHandlerTrait {
-            setFilenameFormat as private typedSetFilenameFormat;
-        }
-
-        public function setFilenameFormat($filenameFormat, $dateFormat)
-        {
-            return $this->typedSetFilenameFormat($filenameFormat, $dateFormat);
-        }
-    }
-} else {
-    class RotatingFileHandler extends BaseRotatingFileHandler
-    {
-        use RotatingFileHandlerTrait;
-    }
+class RotatingFileHandler extends BaseRotatingFileHandler
+{
+    use RotatingFileHandlerTrait;
 }

Import.php

@@ -41,7 +41,7 @@ public function __construct(
         StrategyRepositoryInterface $strategyRepository,
         LoadStrategyRepositoryInterface $loadStrategyRepository,
         ConfigurationInterface $configuration,
-        LoggerInterface $logger = null
+        ?LoggerInterface $logger = null
     ) {
         $this->configuration = $configuration;
         $this->connection = $connection;

ImportConfiguration.php

@@ -20,7 +20,7 @@ public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('import');
 
-        /** @var ArrayNodeDefinition */
+        /** @var ArrayNodeDefinition $rootNode */
         $rootNode = $treeBuilder->getRootNode();
 
         $replaceParameter = function ($string) {

Load/CsvLoader.php

@@ -4,10 +4,10 @@
 
 use Behat\Transliterator\Transliterator;
 use Doctrine\DBAL\Connection;
+use ForceUTF8\Encoding;
 use LePhare\Import\Configuration\CredentialsInterface;
 use LePhare\Import\Exception\ImportException;
 use LePhare\Import\ImportResource;
-use ForceUTF8\Encoding;
 
 /** @api */
 class CsvLoader implements LoaderInterface

Load/ExcelLoader.php

@@ -17,7 +17,7 @@ public function supports(ImportResource $resource, array $context): bool
             return false;
         }
 
-        if (!class_exists(\PhpOffice\PhpSpreadsheet\IOFactory::class)) {
+        if (!class_exists(IOFactory::class)) {
             throw new ImportException('PhpSpreadsheet library is missing. Try "composer require phpoffice/phpspreadsheet"');
         }
 

Load/TextLoader.php

@@ -4,10 +4,10 @@
 
 use Behat\Transliterator\Transliterator;
 use Doctrine\DBAL\Connection;
+use ForceUTF8\Encoding;
 use LePhare\Import\Configuration\CredentialsInterface;
 use LePhare\Import\Exception\ImportException;
 use LePhare\Import\ImportResource;
-use ForceUTF8\Encoding;
 
 /** @api */
 class TextLoader implements LoaderInterface

Tests/ImportConfigurationTest.php

@@ -134,7 +134,7 @@ public function providerConfigurations(): iterable
         ];
 
         yield '“delimiter” should be evaluated' => [
-             array_merge($defaults, [
+            array_merge($defaults, [
                 'name' => $config['name'],
                 'source_dir' => str_replace('%kernel.project_dir%', '/app', $config['source_dir']),
                 'resources' => [

Tests/ImportTest.php

@@ -18,7 +18,6 @@
 use Psr\Log\LoggerInterface;
 use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
-use Symfony\Component\Yaml\Yaml;
 
 /**
  * @covers \LePhare\Import\Import
@@ -112,7 +111,7 @@ public function testExecuteWithException(): void
                         'strategy' => 'load_alphabetically',
                     ],
                 ],
-        ], ]));
+            ], ]));
 
         $this->assertFalse($this->import->execute());
     }
@@ -142,7 +141,7 @@ public function testExecuteWithWrongStrategyShouldFail(): void
                         'strategy' => 'bad_strategy_name',
                     ],
                 ],
-        ], ]));
+            ], ]));
 
         $this->assertFalse($this->import->execute());
     }

phpstan.neon.dist

@@ -6,4 +6,13 @@ parameters:
         - .
     excludePaths:
         - vendor
+    ignoreErrors:
+        -
+            message: '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeParentInterface::.+\(\)#'
+            paths:
+                - ImportConfiguration.php
+        -
+            message: '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition::.+\(\)#'
+            paths:
+                - ImportConfiguration.php
     tmpDir: .phpstan.cache