Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/angular 19 #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JohanHeyvaert
Copy link
Contributor

Hello Nic,

If all goes well, this PR should make ng-hcaptcha compatible with Angular 19.
Could you please review and accept the merge?
Thanks in advance.

Best regards,
Johan

@fcastell
Copy link

Hello Johan,

Thanks for your work.
I have not seen your PR when I create mine for the compatibility with Angular 18.
You have make a mistake:
"@angular/common": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.01",
should be (note the '1' character at the end of version 18):
"@angular/common": "^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0",
See #91 and #89.
Could you please make the correction and I cancel my MR.

Thanks in advance

Best regards,
Fabien

@JohanHeyvaert
Copy link
Contributor Author

Hello Fabien,

Thank you for your remark. I'll fix it right away.

Do you know why it should be .01 instead of .0 ?

Best regards,
Johan

@fcastell
Copy link

Hello Johan, I think it's a typing error (key 1 is above key 0 on the keyboard).

@JohanHeyvaert
Copy link
Contributor Author

Apparently the .01 was already added in this specific PR (not in the previous one for angular 18).

But now I've added an additional commit to update (yet again) all packages, including Angular 19.1.3.

@leNicDev Thank you for reviewing and approving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants