Fixes keyboard navigation in Ktable #900
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have taken the liberty to make several related changes in the
KTable
component:handleKeyDown
event into different internal methods so that the logic of the program is much clearer and maintainable in the futuredisabled
elements as well, so I fixed that as wellTab + Shift
navigation in case multiple focusable elements were present in a single cell. Earlier, if multiple focusable elements were in a cell, they were iterated in the left to right order, even ifTab + Shift
was used, whereas the correct order should be right to left.Tab
navigation and theShift + Tab
navigation were opposite.Ktable
Issue addressed
Fixes #883
Screenshots
LE.mp4
I used the following playground snippet to generate the sample page for testing (on which the demo video is recorded)
Playground
Changelog
KTable
KTable
Testing checklist
Reviewer guidance