-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors #4
base: main
Are you sure you want to change the base?
Conversation
Hello, fellow adventurer @freddycansic! Thank you for submitting this PR; I have resolved build errors (feel free to roll up if you would like) and requested review by @blackdragon2447 since Clippy suggested changing |
@@ -50,7 +50,7 @@ pub enum Window { | |||
Home, | |||
Workspaces { index: usize, empty: bool }, | |||
Tags { index: usize, empty: bool }, | |||
WindowRules { index: usize, empty: bool }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer this stays as WindowRules
instead Rules
, because even though it is Window::WindowRules
, both windows in that are completely disconnected, the window enum is referring to windows in the tui, while the WindowRules
refer to LeftWM window rules.
// Layout::Monocle, | ||
// Layout::RightWiderLeftStack, | ||
// Layout::LeftWiderRightStack, | ||
//]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly remove the commented code fully if we're sure that we're not going to use it again.
@@ -1,4 +1,5 @@ | |||
/target | |||
Cargo.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if Cargo.lock
stays on git, just to make sure builds stay consistent.
Sorry it took me so long to for the review, motivation is kinda all over the place. |
Review addressed on a fork as I wanted to build it =P |
The nightly feature
proc_macro_span_shrink
no longer exists but is being referenced by an oldCargo.lock
file, resulting in a build errorDeleting
Cargo.lock
fixes this.Added
Cargo.lock
to.gitignore
for future commits.