Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from lint.Lint to lint.CertificateLint #7230

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

mcpherrinm
Copy link
Contributor

@mcpherrinm mcpherrinm commented Dec 20, 2023

Zlint is deprecating lint.Lint in favour of lint.CertificateLint.

The main difference is that metadata is now its own struct, shared with lint.RevocationListLint and presumably future lint types.

Zlint is deprecating lint.Lint in favour of lint.CertificateLint.
@mcpherrinm mcpherrinm changed the title Switch from lint.Lint ot lint.CertificateLint Switch from lint.Lint to lint.CertificateLint Dec 20, 2023
These types are the same:

  type LintInterface = CertificateLintInterface

but LintInterface is deprecated.
@mcpherrinm mcpherrinm marked this pull request as ready for review December 20, 2023 22:18
@mcpherrinm mcpherrinm requested a review from a team as a code owner December 20, 2023 22:18
@aarongable aarongable requested a review from a team December 20, 2023 22:20
@pgporada
Copy link
Member

This is related to zmap/zlint#765 and zmap/zlint#767. The CertificateLints interface change made by @aaomidi upstream will be available in zlint 3.6.0, and according to that issue, the Lints interface will be removed in zlint 4.0.

@aarongable aarongable merged commit e331a51 into main Dec 21, 2023
18 checks passed
@aarongable aarongable deleted the mattm-zlint-deprecating-RegisterLint branch December 21, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants