grpc: factor out setup func #7909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a pattern that is new to our tests. setup accepts a variadic list of options, and uses a type switch to make use of those options during setup. This allows us to pass setup only the options that are relevant to any given test case, leaving the rest to sensible defaults.
beautifulentropy
requested changes
Jan 15, 2025
aarongable
approved these changes
Jan 18, 2025
beautifulentropy
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a pattern that is new to our tests. setup accepts a variadic list of options, and uses a type switch to make use of those options during setup. This allows us to pass setup only the options that are relevant to any given test case, leaving the rest to sensible defaults.
Note: this conflicts with #7908, which is fine. I'll resolve conflicts based on whichever one merges first.