Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

likes service #186

Merged
merged 5 commits into from
Feb 20, 2024
Merged

likes service #186

merged 5 commits into from
Feb 20, 2024

Conversation

diegoalzate
Copy link
Contributor

@diegoalzate diegoalzate commented Feb 19, 2024

closes #177

overview

creates a like service and connects it to the comments router

endpoints

  • GET comments/:commentId/likes
  • POST comments/:commentId/likes
  • DELETE comments/:commentId/likes

@diegoalzate diegoalzate added the feature New feature or request label Feb 19, 2024
@diegoalzate diegoalzate self-assigned this Feb 19, 2024
@MartinBenediktBusch MartinBenediktBusch linked an issue Feb 20, 2024 that may be closed by this pull request
@MartinBenediktBusch
Copy link
Collaborator

resolved merge conflicts.

Copy link
Collaborator

@MartinBenediktBusch MartinBenediktBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that we will implement a query in the frontend that gets the total amount of likes by commentId from the likes table in order to display the total amount of likes for a comment. I.e. we do not store the total amount of likes in the backend likes table. Or is that something we should consider doing on the backend? This would require a total likes column in the likes table.

Copy link
Collaborator

@MartinBenediktBusch MartinBenediktBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegoalzate diegoalzate merged commit 325c2b2 into develop Feb 20, 2024
3 checks passed
@diegoalzate diegoalzate deleted the 177-likes-service branch February 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likes service
2 participants