update save votes endpoint #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoalzate
added
minor
MartinBenediktBusch
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Additionaly I encounter the following error when hitting the Save All Votes button in the UI using this branch (in branch develop it works):
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>Cannot GET /api/users/0615974f-1517-41e9-a701-3950ea783c34/cycles/a0767d41-a775-4319-9705-e4eb882f7255/votes</pre>
</body>
</html>
MartinBenediktBusch
approved these changes
Feb 20, 2024
diegoalzate
added
minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #184
overview
accept saving votes as an array of votes you want to save, this will help the frontend not have to loop over changes and just be able to send everything in one request
breaking api changes
The reason why it was moved there it made more sense in hierarchy
function overviews