-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register title and subtitle #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 26, 2024
diegoalzate
suggested changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the decoupling, some small changes requested
diegoalzate
approved these changes
Feb 27, 2024
diegoalzate
added
patch
A patch change is included in this PR
and removed
minor
A minor change is included in this PR
labels
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a
questionOptionType
column to theregistrationFields
data table, which allows to identify whether a registration field is aTITLE
orSUBTITLE
. Furthermore, the PR changes the reference field in thequestionOptions
table from theregistrationFieldId
to theregistrationId
as the registration id is the same for different registration fields belonging to the same user. Lastly, the PR updates and refactors theupdateQuestionOptions
function to allow for the automatic updating of title and subtitle information for the same question options.Note that the implemented functionality is targeted solely to the
berlin
usecase. This is a little bit of a drawback as multiple events and multiple question_ids might not work with the implemented changes. This required a more general setup beyond the berlin usecase.Details about the registration data service update
This PR refactors the
updateQuestionOptions
function to implement the required functionality and improve code clarity. The main changes include:updateQuestionOptions
function is refactored into smaller, more focused functions, each responsible for a specific task. This improves readability and maintainability by breaking down the complex logic into reusable components.filterRegistrationData
andmapToCombinedData
, have been introduced to handle intermediate processing steps:filterRegistrationData
: Filters registration data based on the available registration fields. It takes an array of registration data and registration fields as input and returns filtered registration data that requires updating.mapToCombinedData
: Maps filtered registration data to a combined format suitable for updating/inserting question options. It takes filtered registration data and registration fields as input and returns combined registration data with values grouped by question option type.Testing