Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username to comments endpoint #218

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Add username to comments endpoint #218

merged 4 commits into from
Feb 28, 2024

Conversation

MartinBenediktBusch
Copy link
Collaborator

This PR exposes the username in addition to the userId in the comments api endpoint.

@MartinBenediktBusch MartinBenediktBusch added the patch A patch change is included in this PR label Feb 28, 2024
@MartinBenediktBusch MartinBenediktBusch self-assigned this Feb 28, 2024
@MartinBenediktBusch MartinBenediktBusch linked an issue Feb 28, 2024 that may be closed by this pull request
Get username from comments response #216
Closed
diegoalzate
diegoalzate suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@diegoalzate diegoalzate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets not do migrations for this, just query the user and return the username in the response

@diegoalzate diegoalzate merged commit 0854838 into develop Feb 28, 2024
3 checks passed
@diegoalzate diegoalzate deleted the get-username-from-comments branch February 28, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoalzate diegoalzate diegoalzate approved these changes

@camilovegag camilovegag Awaiting requested review from camilovegag

Assignees

@MartinBenediktBusch MartinBenediktBusch

Labels
patch A patch change is included in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get username from comments response
2 participants
@MartinBenediktBusch @diegoalzate