Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add userId to questionOptions #219

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Add userId to questionOptions #219

merged 4 commits into from
Feb 28, 2024

Conversation

MartinBenediktBusch
Copy link
Collaborator

This PR adds the userId to the questionOptions table. Note that the reference to the userId in the question options table can be null as this allows us to keep inserting custom options into the questionOptions table. Furthermore, note that the userId gets retrieved and uptaded in the questionOptions table upon triggering saveRegistration.

@MartinBenediktBusch MartinBenediktBusch added the patch A patch change is included in this PR label Feb 28, 2024
@MartinBenediktBusch MartinBenediktBusch self-assigned this Feb 28, 2024
@MartinBenediktBusch MartinBenediktBusch linked an issue Feb 28, 2024 that may be closed by this pull request
Add userId to questionOptions #215
Closed
diegoalzate
diegoalzate suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@diegoalzate diegoalzate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

src/db/questionOptions.ts Show resolved Hide resolved
diegoalzate
diegoalzate approved these changes Feb 28, 2024
View reviewed changes
src/db/users.ts Outdated Show resolved Hide resolved
@diegoalzate diegoalzate added feature New feature or request and removed patch A patch change is included in this PR labels Feb 28, 2024
@MartinBenediktBusch MartinBenediktBusch merged commit 223be54 into develop Feb 28, 2024
3 checks passed
@MartinBenediktBusch MartinBenediktBusch deleted the add-userid-to-question-options branch February 28, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoalzate diegoalzate diegoalzate approved these changes

Assignees

@MartinBenediktBusch MartinBenediktBusch

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add userId to questionOptions
2 participants
@MartinBenediktBusch @diegoalzate