add for_user and for_group in registration field #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBenediktBusch
requested review from
MartinBenediktBusch
and removed request for
camilovegag
MartinBenediktBusch
added a commit
that referenced
this pull request
Apr 19, 2024
* add for_user and for_group in registration field (#338) * add migration for boolean registration field flags * add validation for user and group registration fields * Limit one registration per group (#339) * limit one registration per group * clean up logic * add authorization on update registration * fix authorization on an event level --------- Co-authored-by: Diego Alzate <[email protected]>
diegoalzate
added a commit
that referenced
this pull request
Apr 19, 2024
* add question to group category table (#308) * Add group id to registrations (#307) * add new handler to get group registration * remove scripts that will not be used * move getting registration data to its own router * refactor api endpoints * fix tests * fix another test * improve error message * remove migration * merge migrations * add registrations router to api router * add router for categories (#310) Co-authored-by: Martin Benedikt Busch <[email protected]> * extract registration data from handler (#312) * fix only bringing one registration for an event (#316) * Fix typo in events.ts (#317) * Update vote service to allow for different grouping dimensions when calculating the plurality score (#311) * update seed to create questions to group categories * fix tests * update vote service * fix existing tests * fix seed and update tests * test query group category ids * insert dummy uuid to allow IN in sql query * cleanup * remove unused var * Add secret code service (#313) * add migrations for secret * add create group type * update migrations for more control on user settings * create group handler * add join secret group handler * add group from category handler * add tests * add handler to router * fix rename issue * Fix registrations creating new groups (#318) * Bump to version 2.5.0 prerelease * Diego/hide fields on group registration (#323) * remove secret from get category groups endpoint * fix typo on group categories router * add migration to show fields on group registration * Support groups without secret (#326) * update join groups handler to support public groups * remove undefined category with seed * rename key from id to groupId in join group payload * update permissions on scripts * fix tests * Remove the handling of null values (#324) * remove null values from usersToGroups * fix seed and tests * update seed * fix vote service tests * remove null from group handler * Add alerts (#328) * add alerts table * add router for alerts * add title, description and link to alerts * fix build command (#329) * seed a group with group category secrets (#330) * fix groupId not saving (#331) * add for_user and for_group in registration field (#338) * add migration for boolean registration field flags * add validation for user and group registration fields * Limit one registration per group (#339) * limit one registration per group * clean up logic * add authorization on update registration * fix authorization on an event level * adds better validation for fields and register field options in seed (#342) * adds better validation for fields and register field options in seed * make select field not required --------- Co-authored-by: Martin Benedikt Busch <[email protected]> Co-authored-by: Camilo Vega <[email protected]> Co-authored-by: diegoalzate <[email protected]>
MartinBenediktBusch
added a commit
that referenced
this pull request
Apr 22, 2024
* add for_user and for_group in registration field (#338) * add migration for boolean registration field flags * add validation for user and group registration fields * Limit one registration per group (#339) * limit one registration per group * clean up logic * add authorization on update registration * fix authorization on an event level * adds better validation for fields and register field options in seed (#342) * adds better validation for fields and register field options in seed * make select field not required --------- Co-authored-by: Diego Alzate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #337
overview
added new columns for_user and for_group, this allows us to have fields that will show for either of the cases or both. It stops redundancy that we might have needed if used
type: textcolumn.use cases