Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add makefile, docker-compose and migrate to node-postgres #422

Merged
merged 11 commits into from
Jun 13, 2024

Conversation

diegoalzate
Copy link
Contributor

@diegoalzate diegoalzate commented Jun 11, 2024

overview

  • adds docker compose so users can quickly run the database
  • adds makefile to join all cli commands
  • migrates postgres to node-postgres in order to handle pooling connections
  • require node to v20.14.0 so we can load env variables into jest runner
  • updates ci/cd so it is compatible with new environment variables

@diegoalzate diegoalzate requested a review from camilovegag June 12, 2024 09:50
@diegoalzate diegoalzate marked this pull request as ready for review June 12, 2024 09:51
@diegoalzate diegoalzate self-assigned this Jun 12, 2024
@diegoalzate diegoalzate added the feature New feature or request label Jun 12, 2024
@diegoalzate diegoalzate added the patch A patch change is included in this PR label Jun 12, 2024
Copy link
Collaborator

@MartinBenediktBusch MartinBenediktBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@diegoalzate diegoalzate merged commit 595b657 into develop Jun 13, 2024
3 checks passed
@diegoalzate diegoalzate deleted the diego/improve-db-connection branch June 13, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request patch A patch change is included in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants