Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plural score and groups #426

Merged
merged 6 commits into from
Jun 17, 2024
Merged

Conversation

diegoalzate
Copy link
Contributor

@diegoalzate diegoalzate commented Jun 14, 2024

overview

  • cleans up the hardcoded filter for group, now the cycle endpoint will return all of the user's groups and the frontend can define which one to show, probably can filter by required
  • adds a new boolean that can be used to show the score optionally on a question

breaking api changes

  • userCanLeave -> required
  • group is no longer returned in GET cycle, now it returns multiple groups

new api fields

  • added showScore which will be handled by the backend but it can help the frontend know when to render a column

@diegoalzate diegoalzate added the feature New feature or request label Jun 14, 2024
@diegoalzate diegoalzate requested a review from camilovegag June 14, 2024 14:06
@diegoalzate diegoalzate self-assigned this Jun 14, 2024
@MartinBenediktBusch MartinBenediktBusch self-requested a review June 17, 2024 16:10
@diegoalzate diegoalzate merged commit 3021c5d into develop Jun 17, 2024
3 checks passed
@diegoalzate diegoalzate deleted the diego/add-plural-score-and-groups branch June 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants