Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wait channel when buffer full option #3504

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jan 14, 2025

  1. support wait channel when buffer full option
  2. revise kafka sink batch configure

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying January 14, 2025 03:26
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 47.36842% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-1.14@59495ba). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/topo/node/node.go 50.00% 7 Missing and 1 partial ⚠️
internal/topo/planner/sink_planner.go 50.00% 5 Missing and 2 partials ⚠️
internal/topo/node/sink_node.go 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             master-1.14    #3504   +/-   ##
==============================================
  Coverage               ?   63.32%           
==============================================
  Files                  ?      354           
  Lines                  ?    40790           
  Branches               ?        0           
==============================================
  Hits                   ?    25830           
  Misses                 ?    12702           
  Partials               ?     2258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit b9b5af5 into lf-edge:master-1.14 Jan 15, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants