Comments on std hashmap bucket defaults.

libbitcoin · Jan 13, 2025 · e91990f · e91990f
1 parent f180653
commit e91990f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/include/bitcoin/network/async/desubscriber.hpp b/include/bitcoin/network/async/desubscriber.hpp
@@ -74,6 +74,8 @@ class desubscriber final
 
     // These are not thread safe.
     bool stopped_{ false };
+
+    // TODO: optimize, default bucket count is around 8.
     std::map<Key, handler> map_{};
 };
 

diff --git a/include/bitcoin/network/net/hosts.hpp b/include/bitcoin/network/net/hosts.hpp
@@ -140,6 +140,8 @@ class BCT_API hosts
     // These are not thread safe.
     buffer buffer_;
     bool stopped_{ true };
+
+    // TODO: optimize, default bucket count is around 8.
     std::unordered_set<config::authority> authorities_{};
 };
 

diff --git a/include/bitcoin/network/p2p.hpp b/include/bitcoin/network/p2p.hpp
@@ -294,6 +294,7 @@ class BCT_API p2p
     object_key keys_{};
 
     // Guards loopback.
+    // TODO: optimize, default bucket count is around 8.
     std::unordered_set<uint64_t> nonces_{};
 };