-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
BREAKING CHANGE: Switch to using async/await and async iterators.
bdeb578
to
c66cf31
Compare
43afa32
to
7730201
Compare
@@ -1 +0,0 @@ | |||
'use strict' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the example was not even complete and we already have a pubsub example on js-libp2p
, I think that it is not worth to have another one to maintain here.
Ideally, we should look at https://github.com/libp2p/js-libp2p-examples as the way to go? Once I get to automation of the interop for js-libp2p
, I will also look into adding CI jobs for examples and we should probably migrate all examples to there and like in the appropriate repos the examples
e32f0e2
to
8b38471
Compare
8b38471
to
c670d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor feedback right now. The majority of feedback for the pubsub PRs is in the abstract module, libp2p/js-libp2p-pubsub#26. I also left comments that will affect this in the js-libp2p PR libp2p/js-libp2p#467
d7ae2ed
to
a1410d6
Compare
a1410d6
to
f84e744
Compare
1677897
to
50ab805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing but otherwise this looks good. Just a friendly reminder to release as a beta dist-tag when it's ready :)
README.md
Outdated
|
||
```JavaScript | ||
const FloodSub = require('libp2p-floodsub') | ||
|
||
const fsub = new FloodSub(node) | ||
const registrar = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just remove the registrar declaration here and make node that it is a libp2p Registrar? I know we don't have the docs flushed out for that yet, but we can point to that once it's done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are right! Added a comment and removed the declaration. Once we have the docs, I will add a pointer to them here
BREAKING CHANGE: Switch to using async/await and async iterators.
Needs