Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sidebar text layouts and font fallbacks for CJK #964

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

monstorix
Copy link
Contributor

@monstorix monstorix commented Aug 10, 2024

This PR is to fix some CJK display problems for Libredirect's Svelte UI:

  • Sidebar: CJK texts are squashed and displayed vertically because they are wider than latin charaters. (Added min-width: max-content property for this)
  • Options and popup pages do not have fallback fonts, which makes CJK texts appear in a serif font that doesn't quite match the default Inter font. (Added sans-serif as fallback)
  • Fix the translation key for the Service menu.
Before After
before this change after this change

@ManeraKai ManeraKai merged commit 0eb4bba into libredirect:master Aug 10, 2024
3 checks passed
@ManeraKai
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants