Add a MLIR dialect for ghidra pcode. #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlauko
reviewed
May 30, 2024
xlauko
reviewed
May 31, 2024
xlauko
reviewed
Jun 7, 2024
xlauko
reviewed
Jun 17, 2024
Co-authored-by: Henrich Lauko <[email protected]>
pgoodman
suggested changes
Jun 17, 2024
xlauko
reviewed
Jun 18, 2024
lkorenc
reviewed
Jun 18, 2024
| struct mlir_codegen_visitor | ||
| { | ||
| mlir::OpBuilder bld; | ||
| mlir::MLIRContext *ctx; |
There was a problem hiding this comment.
Can it be nullptr? No? Make it a ref, and introduce a type alias.
| using type_t = mlir::Type; | ||
| using value_t = mlir::Value; | ||
| using string_view = std::string_view; | ||
| using values_ref = llvm::ArrayRef< value_t >; |
There was a problem hiding this comment.
Move all of these to some shared header, we are going to use them all over the place.
| visit(inst); | ||
| } | ||
| return bop; | ||
| } |
There was a problem hiding this comment.
This is the same as the one above really.
There was a problem hiding this comment.
Do you mean the cg::operator() method as a whole or just the name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.