Skip to content

Commit

Permalink
Merge pull request #34 from lightstep/fix-ip-addr
Browse files Browse the repository at this point in the history
Use Node IP for kubelet query
  • Loading branch information
jaronoff97 authored Aug 22, 2023
2 parents 0eab047 + 1758d04 commit a393990
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/otel-cloud-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.1
version: 0.1.2

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 4 additions & 0 deletions charts/otel-cloud-stack/templates/collector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ spec:
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: K8S_NODE_IP
valueFrom:
fieldRef:
fieldPath: status.hostIP
- name: K8S_NAMESPACE
valueFrom:
fieldRef:
Expand Down
2 changes: 1 addition & 1 deletion charts/otel-cloud-stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ daemonCollector:
auth_type: "serviceAccount"
insecure_skip_verify: true
# For this scrape to work, the RBAC must have `nodes/stats` GET access.
endpoint: "https://${env:K8S_NODE_NAME}:10250"
endpoint: "https://${env:K8S_NODE_IP}:10250"
extra_metadata_labels:
- container.id
- k8s.volume.type
Expand Down

0 comments on commit a393990

Please sign in to comment.