Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: unknown behavior names: binary, password, username #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ivictbor
Copy link

@ivictbor ivictbor commented Aug 6, 2020

When I tried to pass:

'default': {
        'BACKEND': 'django_ft_cache.FaultTolerantPyLibMCCache',
        'LOCATION': env.str('MEMC_URL'),
        'TIMEOUT': None,
        'OPTIONS': {
            'binary': True,
            'username': env.str('MEMC_USERNAME', None),
            'password': env.str('MEMC_PASSWORD', None),
        }

Package stopped working with

unknown behavior names: binary, password, username

Why did you use _behaviours ?

@ipmb
Copy link
Member

ipmb commented Aug 6, 2020

This was a change in Django 2.0 and the library hasn't been updated to reflect that yet, https://github.com/django/django/blob/stable/2.0.x/django/core/cache/backends/memcached.py#L174-L177

Your change looks good, but we should do a major version bump and update HISTORY.rst with the backwards incompatible change and tox.ini so it is only testing against currently supported Django/Python versions.

@ivictbor
Copy link
Author

ivictbor commented Aug 6, 2020

This was a change in Django 2.0 and the library hasn't been updated to reflect that yet, https://github.com/django/django/blob/stable/2.0.x/django/core/cache/backends/memcached.py#L174-L177

Your change looks good, but we should do a major version bump and update HISTORY.rst with the backwards incompatible change and tox.ini so it is only testing against currently supported Django/Python versions.

Thanks for clear explanations.
I am using my version in production right now, noted tests failed because None in self._options, though when I don't pass OPTIONS in settings.py, works fine also for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants