Use build-args to specify system, version, locale #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposes several small changes. They may or may not benefit the original developer, but they would side-step the "Version bump" PR's 1. Make Java Docker-base a build-argument with default value. * keeps as-is (defaults). * enables upstream changes without conflict resolution or tiny commits. 2. Enables changing PlantUML version by rebuilding the docker image. 3. Makes locale a build-time argument. * It's UTF-8 so should not be an issue, but gives those who care the option. Thanks for making this.
|
@lindt can this be tested and merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes several small changes. They may or may not benefit the original developer, but they would side-step the "Version bump" PR's
Thanks for making this.