-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support adding gRPC interceptors using annotation '@GrpcInterceptor' #5397
Open
Dogacel
wants to merge
13
commits into
line:main
Choose a base branch
from
Dogacel:dogac/5359-add-grpc-interceptor-annotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
756a8e9
support adding gRPC interceptors using annotation '@GrpcInterceptor'
Dogacel d5e5f81
unfortunate linting errors 😢😢
Dogacel de72056
correct path prefix to resolve test failures
Dogacel f528a24
don't split service into methods inside handler registry if no interc…
Dogacel 038aa1a
move logic to Handler Registry
Dogacel ec0b681
fix comment
Dogacel 78e9d53
Merge branch 'main' into dogac/5359-add-grpc-interceptor-annotation
Dogacel b8f90ad
Merge branch 'main' into dogac/5359-add-grpc-interceptor-annotation
Dogacel fb0576b
comment on dep inj
Dogacel 1ffe89d
fix checkStyle
Dogacel 9954ea5
Merge branch 'main' into dogac/5359-add-grpc-interceptor-annotation
Dogacel 89f1b76
fix interception order
Dogacel fdccead
Merge branch 'main' into dogac/5359-add-grpc-interceptor-annotation
Dogacel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
42 changes: 42 additions & 0 deletions
42
grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcInterceptor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/* | ||
* Copyright 2024 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package com.linecorp.armeria.server.grpc; | ||
|
||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Repeatable; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
import com.linecorp.armeria.common.grpc.GrpcExceptionHandlerFunction; | ||
|
||
import io.grpc.ServerInterceptor; | ||
|
||
/** | ||
* Specifies a {@link ServerInterceptor} class which intercepts requests and responses of a gRPC service or its | ||
* methods. | ||
*/ | ||
@Repeatable(GrpcInterceptors.class) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Target({ ElementType.TYPE, ElementType.METHOD }) | ||
public @interface GrpcInterceptor { | ||
|
||
/** | ||
* {@link GrpcExceptionHandlerFunction} implementation type. | ||
*/ | ||
Class<? extends ServerInterceptor> value(); | ||
} |
35 changes: 35 additions & 0 deletions
35
grpc/src/main/java/com/linecorp/armeria/server/grpc/GrpcInterceptors.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/* | ||
* Copyright 2024 LINE Corporation | ||
* | ||
* LINE Corporation licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package com.linecorp.armeria.server.grpc; | ||
|
||
import java.lang.annotation.ElementType; | ||
import java.lang.annotation.Retention; | ||
import java.lang.annotation.RetentionPolicy; | ||
import java.lang.annotation.Target; | ||
|
||
/** | ||
* The containing annotation type for {@link GrpcInterceptor}. | ||
*/ | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Target({ ElementType.TYPE, ElementType.METHOD }) | ||
public @interface GrpcInterceptors { | ||
|
||
/** | ||
* An array of {@link GrpcInterceptor}s. | ||
*/ | ||
GrpcInterceptor[] value(); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.