Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link the Wikipedia page instead of the LY corporation homepage #5840

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Link the Wikipedia page instead of the LY corporation homepage #5840

merged 1 commit into from
Jul 30, 2024

Conversation

trustin
Copy link
Member

@trustin trustin commented Jul 29, 2024 •
edited
Loading

Motivation:

LY corporation's web pages are inaccessible from EU, where our users are.

Modifications:

  • Replaced the URL of LY corporation with its Wikipedia page.

Result:

  • One less broken link

@trustin
Do not use the URLs inaccessible from EU
015d2be 
Motivation:

LY corporation's web pages are inaccessible from EU, where our users
are.

Modifications:

- Replaced the URLs inaccessible from EU with something else.

Result:

- EU users can browse more resources about Armeria and our employer.
@trustin trustin added this to the 1.30.0 milestone Jul 29, 2024
@trustin
Copy link
Member Author

trustin commented Jul 29, 2024

Will undraft once I finish checking other URLs.

ikhoon
ikhoon approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions GitHub Actions
Copy link
Contributor

🔍 Build Scan® (commit: 015d2be)

Job name Status Build Scan®
build-windows-latest-jdk-21 ✅ https://ge.armeria.dev/s/xmjm7667x7tgs
build-self-hosted-unsafe-jdk-8 ✅ https://ge.armeria.dev/s/kjgx4eb6w2fj2
build-self-hosted-unsafe-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/geh4grvprf74s
build-self-hosted-unsafe-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/ntablrevo6ad2
build-self-hosted-unsafe-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/7jla7iwnaogje
build-self-hosted-unsafe-jdk-17-leak ✅ https://ge.armeria.dev/s/vmd4mgsnaw4mg
build-self-hosted-unsafe-jdk-11 ✅ https://ge.armeria.dev/s/hkkahehd5pxti
build-macos-12-jdk-21 ✅ https://ge.armeria.dev/s/3yv2yrmgh2v2y

@minwoox minwoox modified the milestones: 1.30.0, 1.29.4 Jul 29, 2024
minwoox
minwoox approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jrhee17
jrhee17 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@trustin trustin changed the title Do not use the URLs inaccessible from EU Link the Wikipedia page instead of the LY corporation homepage Jul 30, 2024
@trustin trustin marked this pull request as ready for review July 30, 2024 02:47
@trustin trustin merged commit b2684a2 into line:main Jul 30, 2024
15 checks passed
@trustin trustin deleted the eu_accessible_links branch July 30, 2024 02:47
@trustin
Copy link
Member Author

trustin commented Jul 30, 2024

It looks like the EU users cannot access our blog posts as well. Will address this later.

minwoox pushed a commit to minwoox/armeria that referenced this pull request Jul 30, 2024
@trustin @minwoox
Link the Wikipedia page instead of the LY corporation homepage (line#…
e1993ef 
…5840)

Motivation:

LY corporation's web pages are inaccessible from EU, where our users
are.

Modifications:

- Replaced the URL of LY corporation with its Wikipedia page.

Result:

- One less broken link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoox minwoox minwoox approved these changes

@jrhee17 jrhee17 jrhee17 approved these changes

@ikhoon ikhoon ikhoon approved these changes

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
1.29.4
Development

Successfully merging this pull request may close these issues.
4 participants
@trustin @ikhoon @jrhee17 @minwoox