Allow some control characters in a request target #5845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RFC 3986 doesn't prohibit control characters in a request target as long as it's percent-encoded. However, `DefaultRequestTarget` doesn't allow any control characters except `\r` and `\n` in a query string. This is to reject potentially harmful paths such as `/foo\nbar` but it can be overly strict to some users. Modifications: - `DefaultRequestTarget` now allows the following control characters additionally: - TAB (0x09) - FS (0x1C) - GS (0x1D) - RS (0x1E) - US (0x1F) - However, other control characters will remain prohibited until there's a good reason to allow them. - Simplified `appendOneByte()` by introducing additional `BitSet`s of percent-encodable characters. Result: - A user can send and receive an HTTP request whose `:path` contains the following characters now: - TAB (0x09) - FS (0x1C) - GS (0x1D) - RS (0x1E) - US (0x1F)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RFC 3986 doesn't prohibit control characters in a request target as long as it's percent-encoded. However,
DefaultRequestTargetdoesn't allow any control characters except\rand\nin a query string.This is to reject potentially harmful paths such as
/foo\nbarbut it can be overly strict to some users.Modifications:
DefaultRequestTargetnow allows the following control characters additionally:appendOneByte()by introducing additionalBitSets of percent-encodable characters.Result:
:pathcontains the following characters now: