Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #870: Added the stylesheet option to the C API #873

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Fix #870: Added the stylesheet option to the C API #873

merged 3 commits into from
Jan 6, 2025

Conversation

michabay05
Copy link
Contributor

Fix #870. I made slight changes the resvg/crates/c-api/resvg.h and resvg/crates/c-api/lib.rs. Take a look at #870 for more details.

@michabay05 michabay05 mentioned this pull request Dec 26, 2024
Closed
@waywardmonkeys
Copy link
Collaborator

I can review this in about 36-48 hours. Feel free to ping me here if I forget!

@michabay05
Copy link
Contributor Author

@waywardmonkeys

LaurenzV
LaurenzV approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@LaurenzV LaurenzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, although I would like someone with more C knowledge to confirm.

waywardmonkeys
waywardmonkeys reviewed Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes by themselves seem fine, I think. But could you add / modify an example?

@michabay05
Copy link
Contributor Author

I have updated an existing example (resvg/crates/c-api/examples/cairo/example.c) to illustrate how the stylesheet option would apply.

DJMcNab
DJMcNab approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given prior approval from @LaurenzV, I'm happy to land. The C code changes are reasonable.

@DJMcNab DJMcNab merged commit ddd942b into linebender:main Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys left review comments

@LaurenzV LaurenzV LaurenzV approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not set stylesheet path from c via the c-api
4 participants
@michabay05 @waywardmonkeys @DJMcNab @LaurenzV