Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #20

Merged
merged 9 commits into from
Feb 15, 2014
Merged

Redesign #20

merged 9 commits into from
Feb 15, 2014

Conversation

rafinskipg
Copy link

Hi,

This is the first version of the redesign.

I send this pull request so you can see how it's going.

The tasks that we are going to do in the next days are the redesign of the sidebar and doing the last adjustments so it behaves perfectly.

@rafinskipg
Copy link
Author

Related to #17

searls added a commit that referenced this pull request Feb 15, 2014
@searls searls merged commit dbea599 into linemanjs:redesign Feb 15, 2014
@searls
Copy link
Member

searls commented Feb 15, 2014

Sweet, checking it out now. I'll comment a bunch of feedback inline

@searls
Copy link
Member

searls commented Feb 15, 2014

screen shot 2014-02-15 at 12 12 27

Three issues with the landing page:

  1. I'd love for the twitter & github links to land cleanly above the fold
  2. We should definitely retinaify every image
  3. This is exacerbated because of how the fold doesn't line up with every viewport, but as a user scrolls, the switch from "landing screen" to "doc site" is really jarring (no css transition or anything); additionally, if a user scrolls back up they don't get back to the landing page.

@searls
Copy link
Member

searls commented Feb 15, 2014

screen shot 2014-02-15 at 12 16 30

This little lineman glyph doesn't do anything when you click it. Snap to top? Show landing page?

@searls
Copy link
Member

searls commented Feb 15, 2014

lineman transition

Ooh, I really like how the bar disappears and fades back in when the user scrolls up. I think it perhaps should also fade in during any scroll and then disappear when the user has stopped scrolling for a bit. I don't want to risk folks losing the menu button.

@searls
Copy link
Member

searls commented Feb 15, 2014

Oh, on this point, just feel free to push directly to lineman-docs/redesign. You should both have the appropriate access

@rafinskipg
Copy link
Author

Thanks for your feedback, really appreciated. :)

@davemo
Copy link
Member

davemo commented Feb 15, 2014

Loving the look of this, nice work so far @rafinskipg :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants