-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[admin-tool] Venice-specific path filtering logic for ZooKeeper Snapshot and Restore tooling #1047
Conversation
…aths into an output file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My review is still in progress and I still need to go through the main filtering algorithm. But I wanted to leave a partial review so you can start addressing the preliminary comments
clients/venice-admin-tool/src/main/java/com/linkedin/venice/Command.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/Arg.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/Arg.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/CloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/CloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestCloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestCloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/zk_paths.txt
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/venice_paths.txt
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestCloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
…removed unnecessary comments)
clients/venice-admin-tool/src/main/java/com/linkedin/venice/CloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/CloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/TreeNode.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/TreeNode.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestCloneVeniceZKPaths.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Good job
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/main/java/com/linkedin/venice/ZkCopier.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestTreeNode.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestTreeNode.java
Outdated
Show resolved
Hide resolved
clients/venice-admin-tool/src/test/java/com/linkedin/venice/TestZkCopier.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @bonytoni
Venice-specific path filtering logic for ZooKeeper Snapshot and Restore tooling
Overview: To remove ZooKeeper as a potential Single Point of Failure (SPoF) during an outage, we are cloning Venice-specific ZooKeeper paths in the parent region and restoring it in another region's local Zookeeper to continue serving as the primary parent controller and resuming Nuage, VPJ, and Samza operations offline where it left off.
This PR:
ZkCopier.java
VeniceZkPaths.java
Next steps: AdminTool command that clones Venice-specific paths from a source ZK (local or live instance) to a destination ZK (local or live instance)
How was this PR tested?
Unit Testing, Manual Testing
Does this PR introduce any user-facing changes?